Comments (4)
I'm not opposed to a refactor and would certainly entertain a dialogue on the topic. I do however have a few questions below:
- Do you anticipate any breaking changes to the API?
- Are there new features you want to add?
- Would promises be in addition to callbacks or are you suggesting we switch to them fully? (I would be opposed to the latter)
- Generators require Node > 0.11.x (and requires the use of the --harmony flag in some cases). Are you planning on using Babel to make this repo fully ES5 compatible?
You, me and a lot of people rely on this module so I don't want any unexpected surprises for them :)
from shopify-node-api.
Hi @nodeit, thanks for the fast response :)
- For now I don't want to make any breaking changes so callbacks would be still supported.
- For now I have only fixes and better error handling in my mind + better tests.
- See 1.
- I would prefer
babel
andES7
syntax withasync await
and then we would have legacy support.
from shopify-node-api.
@barczaG: all sounds good to me. What's the next step here and do you need anything on my end?
One last thing, in terms of testing I do prefer tape but this is not a sticking point for me if you want to stay with mocha/chai.
from shopify-node-api.
@barczaG I'm going to close this since it's not an "issue" for now. Feel free to reopen when you are ready to get started or if you have any questions for me.
from shopify-node-api.
Related Issues (20)
- GraphQL Support HOT 2
- This module references another github repo in package.json !
- Please add pagination support HOT 1
- Please add the new pagination support
- How do I get the MyShopify address of a user before they are authenticated?
- Getting unwanted text in console when trying to make Get request HOT 1
- Can't get access token and shop info HOT 3
- Are there any sample apps made with this? HOT 1
- Embedded App Authentication HOT 1
- Changelog? HOT 3
- promises? HOT 1
- 404 on charge activation HOT 1
- Error: Signature is not authentic! HOT 1
- Do something when user creates new cart? HOT 2
- Multiple scope does not redirect to Redirect URL HOT 1
- authurl should also be buildable without shopname in url HOT 1
- Error: getaddrinfo 443 when making a request
- Allow gzip encoding HOT 2
- Support Shopify GraphQl call limits HOT 1
- 1000 variant per day API limit not being caught or handled as error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shopify-node-api.