Project does not compile with -Werror about spitool

[chrschmidt]

Actually, in the second part, the negations are a bug that's fixed in my local tree but never was committed.

[chrschmidt]

Thanks for the report. I fixed the second part locally, but totally missed the first one.

[entropyqueen]

Well, since your last commit, you have another issue, it's a missing comma at the end of line 33 in spitool_cmdline.c

spitool_cmdline.c:34:5: error: expected ‘}’ before ‘{’ token
     { "M95256*", 32768, 2, 32, 0, BPDFEEPROM }
     ^
make: *** [Makefile:17: spitool_cmdline.o] Error 1

The array should look like this:

static const bp_device_t spi_devices [] = {
    { "list",        0, 0,  0, 0, BPDFDUMMY },
    { "M95160*",  2048, 2, 32, 0, BPDFEEPROM },
    { "M95320*",  4096, 2, 32, 0, BPDFEEPROM },
    { "M95640*",  8192, 2, 32, 0, BPDFEEPROM },
    { "M95256*", 32768, 2, 32, 0, BPDFEEPROM }
};

[chrschmidt]

Sorry, tried too quickly to merge my local changes.

On 01/08/16 12:50, ark wrote:

Well, since your last commit, you have another issue, it's a missing
comma at the end of line 33 in spitool_cmdline.c

|spitool_cmdline.c:34:5: error: expected ‘}’ before ‘{’ token {
"M95256_", 32768, 2, 32, 0, BPDFEEPROM } ^ make: *_* [Makefile:17:
spitool_cmdline.o] Error 1 |

The array should look like this:

|static const bp_device_t spi_devices [] = { { "list", 0, 0, 0, 0,
BPDFDUMMY }, { "M95160_", 2048, 2, 32, 0, BPDFEEPROM }, { "M95320_",
4096, 2, 32, 0, BPDFEEPROM }, { "M95640_", 8192, 2, 32, 0, BPDFEEPROM },
{ "M95256_", 32768, 2, 32, 0, BPDFEEPROM } }; |

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGJJ_AUqB4rBf4DoMWfoE2cWUP-38Ebks5qbc-MgaJpZM4JZYeB.