signUrl method not accepting PUT or DELETE methods about node-oauth

[ramv]

hmm .. did you close my pull request?

[ciaranj]

Not intentionally!

[ciaranj]

I don't understand this fix ? How does it help with PUT and DELETE ? What are you passing through to signURL ?

[ramv]

forgot add one more diff

296,298c268
<   
<     request.socket.addListener("error",callback);
<     if( method == "POST" && post_body != null && post_body != "" ) {
---
>     if(post_body != null && post_body != "" ) {

321c291

By removing the check for POST, I could get PUT and DELETE to work

[ciaranj]

OK that makes more sense, but I suspect it should say

if( (method == "POST" || method == "PUT) && post_body !=null && post_body != "" ) { 

As I understand it the DELETE verb doesn't define any 'enclosed entity' ?

[ramv]

you are correct.

[ciaranj]

Adds support for PUT & DELETE verbs. Closed by fd2fad5

[ciaranj]

Hi ramv, does this satisfy your requirements ?

[ramv]

Yes it does. Sorry I thought I responded.

[jerryjj]

Shouldn't this fix be copied to oauth2 _request -method also?