Comments (5)
Things you need to consider for accessibility (hint, it's not only aria roles)
- Being able to tab into the component. And respecting the
tabindex
property. - Clicking on a label that has the
for
property set to theid
property of the component, should activate the component. (Thefor
,id
combo also links the label to the component for the screenreader) - Support
aria-labeledby
,aria-describedby
andrequired
. - Needs to respect being disabled when a
<fieldset>
is set to disabled.
from ember-power-select.
Apologies if I am weighing in with things you already know...
This is a favorite reference for me when doing a11y-friendly work. I cannot recommend it highly enough. It nicely digests the relevant portions of the WCAG suggestions for accessibility AND it's broken down by component type with links to some vanilla JS implementations
https://www.w3.org/TR/wai-aria-practices-1.1/#combobox
The examples aren't a perfect matchup for what you have here, but the Dojo combobox with autocomplete does a really good job and isn't far off. role="combobox"
is on the containing <div>
and the use of aria-owns
and aria-expanded
are things I don't see referenced in this issue.
The other advantage of attributes like aria-disabled
and aria-selected
(as referenced in the Listbox
section) is that you can select on them directly in your CSS instead of creating special classes for those states.
from ember-power-select.
@jmacqueen Thanks for the reference. @martndemus did already some work on it, but this is helpful.
from ember-power-select.
Would love required
support..
from ember-power-select.
@knownasilya @jmacqueen I have to get back to the WIP pull request, I hope to get back to it this weekend. See #254
from ember-power-select.
Related Issues (20)
- Documentation missing for Bootstrap and Material themes HOT 2
- Upgrade to the latest version of basic-dropdown HOT 3
- Typing in a PowerSelectMultiple's trigger (when search is disabled) triggers bad onChange
- [email protected] still uses [email protected] HOT 1
- Selected options is undefined after model save HOT 1
- V3 Docs broken
- Autofocus not working
- Ideas to make ebp more accessible
- Interesting performance bottleneck with large list HOT 2
- Drop ember-concurrency-decorators
- incompatible with ember-style-modifier HOT 2
- allow searching by group
- beforeOptionsComponent args are overridden
- Remove deprecation `toArray` (caused by ember-data 4.7+)
- Update app to ember 4.8.x & packages
- Search input in PowerSelectMultiple does not span available width
- onChange not fired when selected value is updated programmaticaly
- release notes for v7.0.0 are missing HOT 3
- Update ember to v4.12 & allow `ember-concurrency 3.x` as dependency
- Embroider doesn't recognize helper? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-power-select.