Comments (6)
"2020" (YYYY valid format) is being flagged invalid.
I thought '2020'
was supposed to be invalid. @griffie Can you clear this up?
- "2020" (YYYY valid format) is being flagged invalid.
- "2020-04" (YYYY-MM valid format) converted to "3/31/20" upon import.
- "2020-01" (YYYY-MM valid format) converted to "12/31/19" upon import.
- **4/4/2020"" (invalid format) converted to "4/4/20".
- "2019-12-20" (YYYY-MM-DD valid format) converted to "12/19/19" upon import.
I reproduced all these. Need to investigate what the date editor is doing.
from dataharmonizer.
2020 should not be considered valid because it's not granular enough. We at least need a month. Actually, we need a day, or else the data will be rejected by GISAID. But as to the issue at hand, "2020" is too vague and needs to be corrected. Is the reason for an invalid entry being provided to the user?
from dataharmonizer.
Nope. It just gets invalidated. Perhaps a grayed out placeholder in such cells that says DD-MM-YYYY would suffice as explanation. Or even adding it to the column label in brackets (DD-MM-YYYY).
Otherwise, they can always double click the header to see the acceptable format.
from dataharmonizer.
Ah, in the guidance it currently says:
ISO 8601 standard "YYYY-MM-DD", "YYYY-MM" or "YYYY".
from dataharmonizer.
You're right. Strictly speaking, that is what the ISO standard allows. We should change the guidance! My bad, my bad... I'll change the text, but can we force a YYYY-MM-DD?
from dataharmonizer.
Yes, definitely. I believe we're enforcing it right now. There's just some bugs on import mentioned in OP.
from dataharmonizer.
Related Issues (20)
- Document the fact that DH JSON is a bare list and not compatible with LinkML tools as is HOT 2
- Implement time and datetime datatypes HOT 2
- Add column help sidebar to core library HOT 2
- Can't install HOT 5
- `linkml.py` does not generate a `schema.js` as expected but a `schema.json` HOT 2
- Schema not loading in DataHarmonizer (only Chrome and Edge; Firefox working) HOT 3
- Adding term normalization / ontology lookup feature to DataHarmonizer HOT 1
- parse() function appears to have repeated regular expression compilation?
- Validation(), specifically setDataAtCell(), can be made much more efficient by eliminating re-render on each column. HOT 2
- Handsontable 13.0.1 and Flatpickreditor.js date column cut/paste challenge HOT 2
- Compress image assets HOT 6
- Customizable Help Menu with Linkage to LinkML generated data model schema documentation HOT 1
- Dropdown picklists including print tags in latest release HOT 3
- Proposal: UI for working with non-enum multivalued slots HOT 2
- Changing the language should depend on the available user interface locales, not schema locales
- JSON Export HOT 3
- Tables should be exportable to a supported template language
- Rework "menu.json", "manifest.json" and "tabular_schema.py" script towards an integrated template publishing workflow
- Multi-sheet Excel export HOT 2
- Importing data and schema configuration from standard JSON file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dataharmonizer.