GithubHelp home page GithubHelp logo

Comments (6)

ivansg44 avatar ivansg44 commented on July 17, 2024

"2020" (YYYY valid format) is being flagged invalid.

I thought '2020' was supposed to be invalid. @griffie Can you clear this up?

  • "2020" (YYYY valid format) is being flagged invalid.
  • "2020-04" (YYYY-MM valid format) converted to "3/31/20" upon import.
  • "2020-01" (YYYY-MM valid format) converted to "12/31/19" upon import.
  • **4/4/2020"" (invalid format) converted to "4/4/20".
  • "2019-12-20" (YYYY-MM-DD valid format) converted to "12/19/19" upon import.

I reproduced all these. Need to investigate what the date editor is doing.

from dataharmonizer.

griffie avatar griffie commented on July 17, 2024

2020 should not be considered valid because it's not granular enough. We at least need a month. Actually, we need a day, or else the data will be rejected by GISAID. But as to the issue at hand, "2020" is too vague and needs to be corrected. Is the reason for an invalid entry being provided to the user?

from dataharmonizer.

ivansg44 avatar ivansg44 commented on July 17, 2024

Nope. It just gets invalidated. Perhaps a grayed out placeholder in such cells that says DD-MM-YYYY would suffice as explanation. Or even adding it to the column label in brackets (DD-MM-YYYY).

Otherwise, they can always double click the header to see the acceptable format.

from dataharmonizer.

ivansg44 avatar ivansg44 commented on July 17, 2024

Ah, in the guidance it currently says:

ISO 8601 standard "YYYY-MM-DD", "YYYY-MM" or "YYYY".

from dataharmonizer.

griffie avatar griffie commented on July 17, 2024

You're right. Strictly speaking, that is what the ISO standard allows. We should change the guidance! My bad, my bad... I'll change the text, but can we force a YYYY-MM-DD?

from dataharmonizer.

ivansg44 avatar ivansg44 commented on July 17, 2024

Yes, definitely. I believe we're enforcing it right now. There's just some bugs on import mentioned in OP.

from dataharmonizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.