fix apple clang github action workflow about faker-cxx

[AdamJovanovic]

I'll give this one a go, I just need to find a way to test what I'm changing. It's interesting to me that the pipeline would have broken between 8899000 and 69524c9

I'll start by checking that clang is added to the PATH correctly, since the Install Clang step does a which clang++ and this returns /usr/bin/clang++, instead of the correct one at /opt/homebrew/opt/llvm@16/bin/clang++

As part of this, it would make sense to have the CMAKE option use -DCMAKE_CXX_COMPILER=clang++, and rely on the PATH instead of hard-coding

[AdamJovanovic]

Actually, the runner version changed somehow between those two commits.
PASSING pipeline uses:

Current runner version: '2.315.0'
Operating System
  macOS
  12.7.4
  21H1123

FAILING pipeline uses:

Current runner version: '2.316.0'
Operating System
  macOS
  14.4.1
  23E224

[cieslarmichal]

Nice catch, the reason is we use macos-latest in https://github.com/cieslarmichal/faker-cxx/blob/main/.github/workflows/macos-clang-build.yml

The solution for this problem would be to fix path to work with latest and pin macos version in pipeline config in file above.

[AdamJovanovic]

PR opened 😄