Comments (5)
To what extent Multicast E2E test is required ?
You definitely want it, or you'll review it if you can afford it ?
We would definitely want it since more functionality is being added to cilium bpf code and cilium-cli,
it is natural that we want some sort of automated testing to ensure that there is no regression
introduced.
There are couple of incentives to get these tests completed sooner rather than later:
- Before we introduce any new functionality to existing multicast implementation (cli or bpf), we should
get e2e tests first. - In order to move this feature out of beta, we need to have e2e tests.
I will be happy to review the changes as well as provide feedback on proposed test scenarios.
from cilium-cli.
How should we prepare a container image by which we can use both IGMP and multicast communication check tool(s) ?
Consider using https://github.com/nicolaka/netshoot container. You can use the socat
utility to send and receive multicast packets; it will also send IGMP to join/leave messages.
http://www.dest-unreach.org/socat/doc/socat-multicast.html
from cilium-cli.
Is it allowed to create a test scenario which affects the state of cilium-agent?
I am not sure if I understand this correctly, cilium agent state is modified by CLIs; is there any other state change you have in mind?
I'd say define the test cases, and we can go over the details of such scenarios.
from cilium-cli.
Some questions:
- To what extent Multicast E2E test is required ?
- You definitely want it, or you'll review it if you can afford it ?
- How should we prepare a container image by which we can use both IGMP and multicast communication check tool(s) ?
- Idea1 : FRR or so on for IGMP and iperf2/socat or so on for multicast communication check
- A test scenario which check the contents of stdout is allowed? (we cannot check using exit-code when using iperf2)
- Idea2 : Using ROS2 and related middleware for both enabling IGMP and checking communication.
- It will become simple but is it allowed to rely on ROS2?
- Idea1 : FRR or so on for IGMP and iperf2/socat or so on for multicast communication check
- Is it allowed to create a test scenario which affects the state of cilium-agent?
- In multicast, remote-node must be registered in each node to achieve communication. (by cilium-dbg or cilium-cli subcommand)
- One idea : Make it a prerequisite for the test that some multicast settings are already included
from cilium-cli.
@harsimran-pabla
Thank you for your comment.
I'll start implementation using socat.
Regarding the third concern, in APAC Dev MTG, I was told that as long as I return to the original state finally, I can put the settings in cilium-agent for testing purposes. (In this case, I would register a multicast group and its remote subscribers to cilium-agent(BPF map of multicast) for E2E test temporarily. )
from cilium-cli.
Related Issues (20)
- CI: GKE test failing due to Cilium test pods getting evicted
- Generating infrastructure architecture overviews/network diagrams for sysdumps
- Add cilium-cli test Job to sysdump
- External workloads - install-external-workload.sh HOT 1
- CI: run cilium-cli inside docker instead of using cilium-cli-test-job-chart helm chart
- CI: port forwarding super flaky on AKS HOT 1
- CI: speedup workflows with test concurrency flag
- Decompose Cilium sysdump part into fine-grained components
- connectivity: --test-concurrency flag doesn't work with --include-conn-disrupt-test HOT 1
- connectivity: single JUnit report for concurrent run HOT 2
- cilium uninstall does not remove cilium resources
- Cilium fails to install on EKS with `bpf.masquerade=true`
- connectivity: check for multiple invocations of WithCondition
- pick up the latest kind version
- Add a --kubeconfig argument HOT 5
- fix local-redirect-policy/lrp-skip-redirect-from-backend
- publish release images
- [connectivity-tests] extend echo-ingress-l7-via-hostport-with-encryption
- `panic: send on closed channel` when issuing CTRL-C while connectivity tests are running on EKS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cilium-cli.