GithubHelp home page GithubHelp logo

Comments (3)

lmb avatar lmb commented on June 25, 2024

Thanks for the detailed report. @brycekahle maybe this is as easy as not generating an error if module BTF doesn't exist?

from ebpf.

brycekahle avatar brycekahle commented on June 25, 2024

Yeah, that would probably work. If the program needs the module BTF then the CO-RE relocations will fail and poison the instructions. That error is a little harder to debug, but will still fail regardless.

from ebpf.

lmb avatar lmb commented on June 25, 2024

The fix is going to be here somewhere:

ebpf/linker.go

Lines 149 to 155 in 7719d2f

if kmodName != "" {
kmodTarget, err := btf.LoadKernelModuleSpec(kmodName)
if err != nil {
return fmt.Errorf("load kernel module spec: %w", err)
}
targets = append(targets, kmodTarget)
}

  • LoadKernelModuleSpec should return a discernible error when the load fails due to the file not existing. Something like errors.Is(err, os.ErrNotFound).
  • The code above should ignore the error if it is due to not being found.

@orishuss are you up for contributing a fix? We can probably test this by using a bogus kmodName and asserting that we don't get an error.

from ebpf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.