GithubHelp home page GithubHelp logo

Rename toJson to asJson about circe HOT 4 CLOSED

circe avatar circe commented on July 22, 2024
Rename toJson to asJson

from circe.

Comments (4)

travisbrown avatar travisbrown commented on July 22, 2024

Yeah, that makes sense. I was thinking to made the fact that it's a conversion a little clearer, but I could go either way.

We might need to make some changes in the benchmarks as well, since I use toJson side by side with Argonaut's asJson—I don't know off the top of my head whether they'll work together if they have the same name.

from circe.

vkostyukov avatar vkostyukov commented on July 22, 2024

We can also go other way: use to[Foo] on jfc's Json instead of as[Foo]. But it will make it a bit harder for people to migrate from Argonaut to jfc.

from circe.

propensive avatar propensive commented on July 22, 2024

My general rule is that a method called to takes a type constructor, whereas a method called as takes a proper type.

from circe.

travisbrown avatar travisbrown commented on July 22, 2024

I think that to me to means conversion, and specifically conversion that can fail, while as is more like safe casting or interpretation—but that's exactly the opposite of my current API, so I'm clearly not thinking too consistently about this stuff.

I say let's go with @propensive's rule and @vkostyukov's suggestion and use as[A] and asJson.

from circe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.