GithubHelp home page GithubHelp logo

Reconsider integral decoders about circe HOT 4 CLOSED

circe avatar circe commented on July 22, 2024
Reconsider integral decoders

from circe.

Comments (4)

ceedubs avatar ceedubs commented on July 22, 2024 1

@travisbrown I think the "1.0" example should probably be supported. It's one of those things where you don't really care until for some reason you are getting JSON of this form and it's a hassle if your JSON lib chokes on it.

So would the rule be that there can be trailing zeros after the decimal place but any other numbers would cause Short, Int, or Long parsing to fail?

BTW I also don't feel super strongly about this. Luckily circe makes it very easy to customize decoders, so one could work around whatever you make the default.

from circe.

ceedubs avatar ceedubs commented on July 22, 2024

@travisbrown I agree. What about io.circe.parse.decode[Short]("1.0")?

from circe.

travisbrown avatar travisbrown commented on July 22, 2024

@ceedubs I'd prefer to have it fail, but I think that's a case where we may need to be flexible because of real-world JSON usage. What do you think?

from circe.

julienrf avatar julienrf commented on July 22, 2024

I agree.

from circe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.