Update PR template checklists so usage indicates required items about .github

[jsf9k]

What say you to these changes, @felddy and @mcdonnnj?

Edit: I now see that @mcdonnnj gave me a thumbs up reaction above.

[mcdonnnj]

• Changes are limited to a single goal (no scope creep) - we are all guilty of this!!!

We probably need to remember that one in reviews as well honestly.

[hillaryj]

Here's some changes I'd recommend; first is the raw, followed by the markup version:

# <!-- Use the title to describe PR changes in the imperative mood --> #

<!-- Follow the conventions of great Git commit messages from -->
<!-- https://chris.beams.io/posts/git-commit/ -->

## 🗣 Description ##

<!-- Describe the "what" of your changes in detail -->
<!-- To avoid scope creep, limit changes to a single goal -->

## 💭 Motivation and Context ##

<!-- Why is this change required? -->
<!-- What problem does this change solve? How did you solve it? -->
<!-- Link to any related issue(s) here to auto-close it on merge. -->

## 🧪 Testing ##

<!-- How did you test your changes? How could someone else test this PR? -->

<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->

## 📷 Screenshots ##

<!-- Remove this section and header if not needed -->

## 🚥 Types of Changes ##

<!-- What types of changes does your code introduce? -->
<!-- Add any relevant types and remove any that don't apply -->
<!-- Consider making a PR against the template for new types -->

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (causes existing functionality to change)
- Documentation change or update

## ✅ Checklist ##

<!-- Remove any of the following that do not apply. -->
<!-- Draft PRs should have several un-checked boxes still to go -->
<!-- If you're unsure about any of these, don't hesitate to ask. -->
<!-- We're here to help! -->

- [ ] PR has an informative and human-readable title
- [ ] Changes are limited to a single goal (no scope creep)
- [ ] Future todos are captured in issues and/or comments
- [ ] Added assignee and relevant labels
- [ ] I have read the [CONTRIBUTING](../blob/develop/CONTRIBUTING.md) document
- [ ] Code changes follow [cisagov code standards](https://github.com/cisagov/development-guide)
- [ ] Updated repo/project documentation to reflect changes in this PR
- [ ] Added tests to cover my changes
- [ ] All new and existing tests pass

🗣 Description

💭 Motivation and Context

🧪 Testing

📷 Screenshots

🚥 Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (causes existing functionality to change)
• Documentation change or update

✅ Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Future todos are captured in issues and/or comments
• Added assignee and relevant labels
• I have read the CONTRIBUTING document
• Code changes follow cisagov code standards
• Updated repo/project documentation to reflect changes in this PR
• Added tests to cover my changes
• All new and existing tests pass

[hillaryj]

Totally agree! In the way that Github displays checklist summaries, it's expecting them to be required items like "acceptance criteria" or "things that must be complete to consider this work Done."

Here's the CFPB's PR template checklist, for a possibly helpful example: https://github.com/cfpb/consumerfinance.gov/blob/main/.github/PULL_REQUEST_TEMPLATE.md#checklist

[jsf9k]

Here's the CFPB's PR template checklist, for a possibly helpful example: https://github.com/cfpb/consumerfinance.gov/blob/main/.github/PULL_REQUEST_TEMPLATE.md#checklist

I heartily endorse the addition of these thangs from the CFPB PR template:

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep) - we are all guilty of this!!!
• Future todos are captured in comments and/or tickets - ditto!!!

[dav3r]

☑️ I'm on board with these changes! 👍

[jsf9k]

• Changes are limited to a single goal (no scope creep) - we are all guilty of this!!!

We probably need to remember that one in reviews as well honestly.

Very good point. We'll have to work to keep each other honest.