GithubHelp home page GithubHelp logo

TestCodecGPBBasic fails about pipeline-gnmi HOT 4 OPEN

cisco-ie avatar cisco-ie commented on August 22, 2024
TestCodecGPBBasic fails

from pipeline-gnmi.

Comments (4)

remingtonc avatar remingtonc commented on August 22, 2024

This test passes in the original bigmuddy repo and the testdata and test itself is the same - this is a failure introduced in this repo.

from pipeline-gnmi.

BenderScript avatar BenderScript commented on August 22, 2024

Very interesting. Does the old repo test against recent Go versions? Looking at your description this issue seems like something related to JSON tags such asomitempty.

from pipeline-gnmi.

remingtonc avatar remingtonc commented on August 22, 2024

This does appear to be due to the updated vendor dependencies. Copying the vendor/ folder from this project to original pipeline repository yields the same failures.
The crux of the failure is this inclusion: data_gpb:<nil> data_gpbkv:[]
The proto: https://github.com/cisco-ie/pipeline-gnmi/blob/master/vendor/github.com/cisco/bigmuddy-network-telemetry-proto/proto_go/telemetry.pb.go#L85-L89
Should these fields be in the output?

from pipeline-gnmi.

BenderScript avatar BenderScript commented on August 22, 2024

These values should not be there if marshaled correctly. Interestingly these are the only pointers in the struct and although the definition of empty should be straightforward these are very nested custom types.

from pipeline-gnmi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.