Building errors when using '-Wno-non-virtual-dtor' about openh264

[licaiguo]

Can you post sample code to use openh264?

[ArikYa]

Just using hello world application that link with the api definitions:
test.cpp:

#include <stdio.h>
#include "codec/api/svc/codec_api.h"

int main(int argc, char *argv[])
{
    printf("Hello world!");
    return 0;
}

If I compile it with -Wnon-virtual-dtor, I get a warning, and if I include -Werror, it fails:

gcc -Wnon-virtual-dtor -Werror -o test.o test.cpp

the result is:

./codec/api/svc/codec_api.h:54:7: error: 'ISVCEncoder' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class ISVCEncoder {
      ^
./codec/api/svc/codec_api.h:95:7: error: 'ISVCDecoder' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class ISVCDecoder {
      ^
2 errors generated.

When trying to use OpehH264 together with WebRTC, the Android native code builds with these two options, so it fails. I think that fixing this in the OpenH264 code is the right place to do it.

[licaiguo]

This issue is fixed in pull request #725.

[ArikYa]

Thanks