GithubHelp home page GithubHelp logo

Duplicate symbols in assembly about openh264 HOT 5 CLOSED

cisco avatar cisco commented on August 17, 2024
Duplicate symbols in assembly

from openh264.

Comments (5)

ekr avatar ekr commented on August 17, 2024

OK, just renaming all the decoder functions seems to solve this problem.
I can now do 640x480 at about 110% on my air.

It's probably worth seeing which functions are really redundant and
can be removed and which can be renamed.

I can provide a hacky patch to do the rename, but I figure someone from
Cisco (volvet?) will probably just want to fix it in a better way. Let
me know.

from openh264.

licaiguo avatar licaiguo commented on August 17, 2024

The prototype of intra-prediction in decoder & encoder is different. I will rename it and send a pull request to fix it.

from openh264.

volvet avatar volvet commented on August 17, 2024

Thanks Licai & Ekr. The confliction is in intra-pred and deblocking. the intra-pred in decoder will reconstruct the pixel into the dec-picture, the one in encoder will reconstruct the pixel into mb cache for mode decision. Maybe rename is the fast way to fix it.
the deblocking assembly function is common module, we need to build it into libcommon.a, not encoder or decoder lib, so it should not be conflicted.
Ekr, after Licai push his change, could you try again and let us know the result?

from openh264.

ekr avatar ekr commented on August 17, 2024

Volvet:

Yes, I will be around for another 3 hrs or so, or I can check tomorrow AM.

If you just want to try it experimentally, push it to a private branch and I willl
do a pull and check,

from openh264.

volvet avatar volvet commented on August 17, 2024

The issues should be fixed since the conflict symbol have been to move to common.

from openh264.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.