Components generated with hygen break pre commit hook about rover-ui

[mikemfleming]

I've been banging my head on this for a second. It seemed as easy as fixing the template file but that opened up a can of works when testing generate-component and committing it. I can't seem to resolve this error:

[pre-commit:lint ] /Users/mike.fleming/Documents/rover-ui/example/src/App.tsx
[pre-commit:lint ] 0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
[pre-commit:lint ] The file does not match your project config: example/src/App.tsx.
[pre-commit:lint ] The file must be included in at least one of the projects provided

[pixelbandito]

Hmmm... parserOptions.project: "tsconfig.json" in .eslintrc
tsconfig.json explicitly excludes the example folder.

Did you try un-excluding the example folder from tsconfig? Or maybe add a new example/.eslintrc file that disables type-aware linting.

(I'd like to keep linting it as much as possible, though.)

P.S. What do you mean testing generate-component and committing it? You don't need to change example/src/App to update the story extension in the hygen template, do you?

[mikemfleming]

Ah I figured out what the issue was with the excludes. ESLint ranks our .eslintignore file as higher priority than an excludes property I guess.

[mikemfleming]

P.S. What do you mean testing generate-component and committing it? You don't need to change example/src/App to update the story extension in the hygen template, do you?

I meant that after making changes to the hygen template I made a new test component and checked that I could commit it without any issues. Without the changes in the pr I'm putting up it would fail linting.