Unable to run app.get() for some objects in a knack form due to datetime issue about knackpy

[johnclary]

@jenna-jordan I just ran a quick test of _correct_knack_timestamp

import datetime
import pytz

timezone = pytz.timezone("America/New_York")
mills_timestamp = -55903046400000
timestamp = mills_timestamp / 1000
dt_utc = datetime.datetime.fromtimestamp(timestamp, tz=datetime.timezone.utc)
dt_naive = dt_utc.replace(tzinfo=None)
dt_local = timezone.localize(dt_naive)

No issue, the result looks fine:

datetime.datetime(198, 7, 3, 0, 0, tzinfo=<DstTzInfo 'America/New_York' LMT-1 day, 19:04:00 STD>)

Reading the datetime docs, this might be a platform-specific issue. Are you running this on Windows?

if the timestamp is out of the range of values supported by the platform C localtime() function, and OSError on localtime() failure. It’s common for this to be restricted to years from 1970 through 2038.

Here's an SO post with the cross-platform way to handle this. TIL. I'd estimate this as a 1 to patch it. Will be backwards compatible.

I believe we're going to talk internally next week about how our team is going to prioritize these fixes going forward. In the meantime feel free to submit a PR @jenna-jordan.

cc @mateoclarke @frankhereford

[jenna-jordan]

When I was running this in the debugger, I was on a Windows computer. When we run workflows in production, they are run in a docker container running Ubuntu. I will test out to see if the problem occurs using Ubuntu as well.

[jenna-jordan]

Confirmed that it runs fine in the docker container (Ubuntu) - seems the issue is only with Windows.
cc @johnclary