Comments (2)
We needed to move more icons that we initially expected, because they are used by more than one package.
Icons moved to the @ckeditor/ckeditor5-core
package:
undo.svg
andredo.svg
from theundo
package.bulletedlist.svg
,numberedlist.svg
, andtodolist.svg
from thelist
package.codeblock.svg
from thecode-block
package.browse-files.svg
from theckbox
andckfinder
packages.heading1.svg
,heading2.svg
,heading3.svg
,heading4.svg
,heading5.svg
, andheading6.svg
from theheading
package.horizontalline.svg
from thehorizontal-line
package.html.svg
from thehtml-embed
package.indent.svg
andoutdent.svg
from theindent
package.table.svg
from thetable
package.
Icons moved to the ckeditor5-collaboration
package:
robot-pencil.svg
from theai
package.table-of-contents.svg
from thedocument-outline
package.paint-roller.svg
from theformat-painter
package.template.svg
from thetemplate
package.
from ckeditor5.
Problem
Unfortunately, suggested way of resolving name conflict with findOptimalInsertionRange
has failed.
After merging findOptimalInsertionRange
from widget
and engine
package and moved it to the Schema
as a method, one more function ( getTypeAroundFakeCaretPosition
) was needed to be imported from widgettypearound/utils
.
After createing an export in index.ts
in widget
package:
export { getTypeAroundFakeCaretPosition } from './widgettypearound/utils';
and trying to import it in Schema
we get an errors (unable to run anything with widget
) - it was caused by that widget
has imports from engine
and engine
has imports from widget
.
Solution
We decided to change the way how we will handle it: move findOptimalInsertionRange
from engine
to the Schema
as a method, but leave findOptimalInsertionRange
in widget
but not import it from engine
but use model.schema.findOptimalInsertionRange()
. 👉 7875f7f
from ckeditor5.
Related Issues (20)
- Docs issue report from "installation/advanced/using-two-editors.html"
- The splitbutton divider is not placed correctly when toolbar is decoupled HOT 8
- Method to convert view to model. HOT 2
- Comment adapter (getCommentThread) method is getting called twice in Angular
- Docs issue report from "installation/advanced/content-styles.html" HOT 1
- Issue - CKEditor can't be used as JSX component HOT 8
- Heading plugin typescript definitions: support user-defined models? HOT 9
- Docs issue report from "framework/deep-dive/conversion/helpers/downcast.html" HOT 4
- [Safari] Page content gets selected while dragging dialog window
- Cryptic error in the Math equations and chemical formulas guide HOT 3
- Types issues in headings
- Highlight html syntax HOT 1
- Change font color of selected text in RTE? HOT 3
- Can I modify 'TrackChangesEditing' plugin's suggestion tag id?
- Release 41.1.0 docs review
- The toolbar is obscured by a custom head HOT 1
- Do not use element reference in `DifferItemInsert` and `DifferItemRemove` HOT 1
- Table/cell properties hsl values don't honour RTL HOT 1
- After adding toolbar it is giving an error HOT 4
- Not able to Increase Hight of Editor HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ckeditor5.