GithubHelp home page GithubHelp logo

Comments (2)

filipsobol avatar filipsobol commented on May 28, 2024 2

We needed to move more icons that we initially expected, because they are used by more than one package.

Icons moved to the @ckeditor/ckeditor5-core package:

  • undo.svg and redo.svg from the undo package.
  • bulletedlist.svg, numberedlist.svg, and todolist.svg from the list package.
  • codeblock.svg from the code-block package.
  • browse-files.svg from the ckbox and ckfinder packages.
  • heading1.svg, heading2.svg, heading3.svg, heading4.svg, heading5.svg, and heading6.svg from the heading package.
  • horizontalline.svg from the horizontal-line package.
  • html.svg from the html-embed package.
  • indent.svg and outdent.svg from the indent package.
  • table.svg from the table package.

Icons moved to the ckeditor5-collaboration package:

  • robot-pencil.svg from the ai package.
  • table-of-contents.svg from the document-outline package.
  • paint-roller.svg from the format-painter package.
  • template.svg from the template package.

from ckeditor5.

pszczesniak avatar pszczesniak commented on May 28, 2024

Problem

Unfortunately, suggested way of resolving name conflict with findOptimalInsertionRange has failed.

After merging findOptimalInsertionRange from widget and engine package and moved it to the Schema as a method, one more function ( getTypeAroundFakeCaretPosition ) was needed to be imported from widgettypearound/utils.
After createing an export in index.ts in widget package:

export { getTypeAroundFakeCaretPosition } from './widgettypearound/utils';

and trying to import it in Schema we get an errors (unable to run anything with widget) - it was caused by that widget has imports from engine and engine has imports from widget.

Solution

We decided to change the way how we will handle it: move findOptimalInsertionRange from engine to the Schema as a method, but leave findOptimalInsertionRange in widget but not import it from engine but use model.schema.findOptimalInsertionRange(). 👉 7875f7f

from ckeditor5.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.