listen-live looses event information about enfocus

[twillis]

ok, well I tried, but I'm not able to run lein test on the project. alas, here's a patch that describes what I was thinking.

--- a/src/cljs/enfocus/events.cljs
+++ b/src/cljs/enfocus/events.cljs
@@ -85,7 +85,7 @@
     (conj (get-node-chain top (.-parentNode node)) node)))

 (defn- create-event [type cur tar]
-  (let [event (goog.events.Event. type)]
+  (let [event (or (.init type tar) (goog.events.Event. type))]
     (set! (.-currentTarget event) cur)
     (set! (.-target event) tar)
     event))

[ckirkendall]

You need to have phantom JavaScript engine installed to run the tests.
Unfortunately, I am still concerting the event test over to new
structure. I think using goog.object to clone the original event and then
set the current target might be our best option.
On Dec 31, 2013 7:53 PM, "Tom Willis" [email protected] wrote:

ok, well I tried, but I'm not able to run lein test on the project. alas,
here's a patch that describes what I was thinking.

--- a/src/cljs/enfocus/events.cljs+++ b/src/cljs/enfocus/events.cljs@@ -85,7 +85,7 @@
(conj (get-node-chain top (.-parentNode node)) node)))

(defn- create-event [type cur tar]- (let [event (goog.events.Event. type)]+ (let [event (or (.init type tar) (goog.events.Event. type))](set! %28.-currentTarget event%29 cur)
(set! (.-target event) tar)
event))

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/87#issuecomment-31416460
.

[ckirkendall]

I did some testing and ended up cloning the original event and setting the currentTarget to solve the issue.

[ckirkendall]

If you could can you pull down the newest 2.1.0-SNAPSHOT and validate it solves your issue.

[twillis]

sure, i'll do that this evening, about to go get my hobbit on now :)

[twillis]

just gave it a go and it works as expected. thanks so much for the change over the holidays.