GithubHelp home page GithubHelp logo

Comments (7)

viktorix avatar viktorix commented on May 5, 2024 1

@bahiirwa there are a few reasons not to use GitHub API directly:

  1. Privacy. Main issue. GitHub API will log all requests. Users wouldn't even know they're sharing their IP with GitHub.
  2. Maintenance of the widget. Just like now, if we need to freeze API results to make changes to the widget, we wouldn't be able to do it since we wouldn't have control over the API.
  3. Gives us more control over what we can do with the data.
  4. GitHub API returns a lot of unnecessary data. So we can clean it up and return only the necessary data for the widget to work.

from classicpress.

bahiirwa avatar bahiirwa commented on May 5, 2024

We can't have CP websites requesting data from GitHub API directly.

Could your throw more light on this?

This is because we shall be making a redirect/"reverse proxy" of sort. Unless we choose to save this information in some place before distributing it.

from classicpress.

viktorix avatar viktorix commented on May 5, 2024

I've made some progress on the feature request widget. I've modified HTML/CSS while still using old API data:

image

from classicpress.

viktorix avatar viktorix commented on May 5, 2024

We need to modify JSON generator script to get data from GitHub, which is triggered periodically using a cronjob.

The following is a proposed JSON format based on the current API:

{
    "recent": {
        "data": [{
                "title": "items->{}->title",
                "status": "open",
                "link": "items->{}->url"
            },
            {
                "title": "items->{}->title",
                "status": "open",
                "link": "items->{}->url"
            }
        ]
    },
    "in-progress": {
        "data": [{
                "title": "items->{}->title",
                "status": "needs-pr",
                "link": "items->{}->url"
            },
            {
                "title": "items->{}->title",
                "status": "has-pr",
                "link": "items->{}->url"
            }
        ]
    },
    "help-wanted": {
        "data": [{
                "title": "items->{}->title",
                "status": "open",
                "link": "items->{}->url"
            },
            {
                "title": "items->{}->title",
                "status": "open",
                "link": "items->{}->url"
            }
        ]
    },
    "link": "https://github.com/ClassicPress/ClassicPress/issues?q=is%3Aopen+is%3Aissue+label%3A%22type%3A+feature+request%22"
}

Categorization

We have 3 categories: recent, in-progress, and help wanted

recent

Pull the most recent 10 open issues using the label "type: feature request" and the following statuses:

  • status: discussion
  • status: on hold
  • status: need more info
  • status: needs decision

When passing status label to the JSON file, please remove "status: ".

https://api.github.com/search/issues?q=is%3Aissue+is%3Aopen+label%3A%22type%3A+feature+request%22+repo:classicpress/classicpress

in progress

Pull open issues labeled "type: feature request" and the following statuses:

  • status: has pr
  • status: needs pr
  • status: research plugin
  • status: needs test
  • status: needs review
  • status: community reviewed

When passing status label to the JSON file, please remove "status: ".

https://api.github.com/search/issues?q=is%3Aissue+is%3Aopen+label%3A%22type%3A+feature+request%22+repo:classicpress/classicpress

help wanted

Pull the latest 10 open issues with label "help wanted".
When passing status label to the JSON file, please remove "status: ".

https://api.github.com/search/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+repo:classicpress/classicpress

from classicpress.

bahiirwa avatar bahiirwa commented on May 5, 2024

Thank you for the well detailed requirement. This comment might need to be an issue on APIs repo.

However, We need to keep the current issue for the dashboard modification in core.

from classicpress.

mattyrob avatar mattyrob commented on May 5, 2024

Please can we have a progress report on this proposal.

Is there a possibility of a PR soon? 1.5.0 is nearing Release Candidate phase, without a PR soon we may need to consider deferring this until 1.6.0.

from classicpress.

viktorix avatar viktorix commented on May 5, 2024

@mattyrob bump it to 1.6.0. This requires API changes that haven't been implemented yet.

from classicpress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.