Comments (3)
@clauderic Sounds fair. I mostly wanted to post this for anyone in the future looking to go down the component route. Thanks.
from react-sortable-hoc.
I'm finding the component way easier as well. I'm using this:
import React, { PropTypes } from 'react';
import { SortableContainer, SortableElement, SortableHandle } from 'react-sortable-hoc';
export const SortHandle = SortableHandle(({ children }) => children);
export const SortElement = SortableElement(({ children }) => children);
export const SortContainer = SortableContainer(({ children, wrapper = 'div' }) =>
React.createElement(wrapper, { children })
);
SortHandle.propTypes = { children: PropTypes.node };
SortElement.propTypes = { children: PropTypes.node };
SortElement.propTypes = {
children: PropTypes.node,
wrapper: PropTypes.string.isRequired
};
from react-sortable-hoc.
Hey @dbachrach, thanks for sharing this. I think it's a neat approach for people who'd rather go down the component route.
Having said that, the idea is to keep react-sortable-hoc
as flexible as possible to ensure compatibility with as many other components / libraries as possible, which is why I still privilege the HOC approach.
I'm going to close this issue because I see this as a non-issue and don't want newcomers to be under the impression that there are plans to move in this direction. Feel free to re-open with a PR if you feel strongly about this, and we can discuss there.
from react-sortable-hoc.
Related Issues (20)
- Notice for new consumers does not show up on npm
- bug
- Uncaught TypeError: cannot call a class as a function HOT 1
- When will react18 be supported?
- type error warning JSX component in typescript
- Create a drop UI state on the Sections showing the area where the selected section can be moved
- Type mistake For "React.FC" HOT 1
- not working on "react": "^18.2.0", HOT 2
- Child component state is reset to initial state if any state of parent component is changed
- shouldCancelStart is not a function HOT 1
- How to detect the boundary of the collection of current being dragged row? HOT 1
- TypeError: Cannot read properties of undefined (reading 'add') HOT 1
- getScrollingParent's "el instanceof HTMLElement" logic will cause some problems
- tabs not working in react sortable hoc
- not able to use with [email protected] HOT 3
- Large Data HOT 1
- when there is input field in the sortableElement than input field is loosing focus on every key press
- Dispatch state before drag starts is taking effect only when the mouse is released. HOT 2
- any way to use column and row drag in one table
- react 18.2.0 installing issue please update this package HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-sortable-hoc.