Comments (3)
None of these points answer, why a custom container couldn't be provided as an optional prop
from react-sortable-hoc.
There are a number of reasons for this, but long story short, it causes a lot more headaches than it solves. The challenges that arise when you try to append the element to the container instead of the body greatly outweigh the small benefits you get. Inevitably you end up needing a wrapper div to solve some of these challenges, which wouldn't make this component a HOC anymore. Feel free to try it for yourself :)
Also:
- If you add the helper to it's container, it's susceptible to being hidden by
overflow: scroll
oroverflow:hidden
. - There are a number of css glitches in Safari on iOS related to fixed positioning nested elements.
- Sometimes adding the helper to the container is simply not an option in the context of a HOC, for instance, if you're enhancing a
react-virtualized
orreact-infinte
list, nevermind the fact that touch events stop firing when thee.target
gets removed from the DOM.
If you're using css-modules
(if not, you should really give it a shot), this isn't really an issue either.
from react-sortable-hoc.
I see, thank you for this explanation.
from react-sortable-hoc.
Related Issues (20)
- Notice for new consumers does not show up on npm
- bug
- Uncaught TypeError: cannot call a class as a function HOT 1
- When will react18 be supported?
- type error warning JSX component in typescript
- Create a drop UI state on the Sections showing the area where the selected section can be moved
- Type mistake For "React.FC" HOT 1
- not working on "react": "^18.2.0", HOT 2
- Child component state is reset to initial state if any state of parent component is changed
- shouldCancelStart is not a function HOT 1
- How to detect the boundary of the collection of current being dragged row? HOT 1
- TypeError: Cannot read properties of undefined (reading 'add') HOT 1
- getScrollingParent's "el instanceof HTMLElement" logic will cause some problems
- tabs not working in react sortable hoc
- not able to use with [email protected] HOT 3
- Large Data HOT 1
- when there is input field in the sortableElement than input field is loosing focus on every key press
- Dispatch state before drag starts is taking effect only when the mouse is released. HOT 2
- any way to use column and row drag in one table
- react 18.2.0 installing issue please update this package HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-sortable-hoc.