Why not to use PhpDoc sections? about simpleimage

[claviska]

It's personal preference, and I simply don't use it.

On Jul 7, 2013, at 5:00 AM, Nazar Mokrynskyi [email protected] wrote:

PhpDoc comments makes easier to work with class and it's methods, than current variant, which is not recognized by IDE.

—
Reply to this email directly or view it on GitHub.

[seyDoggy]

I'll be honest, phpdoc was tough to get used to writing at first but it's value quickly became apparent. The style is becoming fairly ubiquitous across Java, JavaScript and many other languages so sight-reading various source code in other languages becomes very familiar.

Adam Merrifield
seyDoggy vCard: seyDoggy.com/vcard

On Sunday, 7 July, 2013 at 9:13, Cory LaViska wrote:

It's personal preference, and I simply don't use it.

On Jul 7, 2013, at 5:00 AM, Nazar Mokrynskyi [email protected] wrote:

PhpDoc comments makes easier to work with class and it's methods, than current variant, which is not recognized by IDE.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub (#16 (comment)).

[nazar-pc]

I wrote PhpDoc comments for this class, added namespace, merged useful changes of forks of this class, and added some other features like progressive jpeg, rgb and rgba colors support and some refactoring.

In most places it is compatible with original version, but with several exceptions.

This all now in my fork and I want to make a pull request into upstream, to show this all to other people, I hope changes will be useful for them.

I marked forked version as 2.1, not sure is it correct or no, but anyway.

[seyDoggy]

I added name spacing to my fork as well but my pull request was rejected.

Adam Merrifield
seyDoggy vCard: seyDoggy.com/vcard

On Sunday, 7 July, 2013 at 10:32, Nazar Mokrynskyi wrote:

I wrote PhpDoc comments for this class, added namespace, merged useful changes of forks of this class, and added some other features like progressive jpeg, rgb and rgba colors support and some refactoring.
In most places it is compatible with original version, but with several exceptions.
This all now in my fork and I want to make a pull request into upstream, to show this all to other people, I hope changes will be useful for them.
I marked forked version as 2.1, not sure is it correct or no, but anyway.

—
Reply to this email directly or view it on GitHub (#16 (comment)).

[claviska]

@seyDoggy — I've taken some time to read more about 5.3's namespacing features. I'll likely be accepting @nazar-pc's pull request after I have additional time to review everything. Nothing personal—I appreciate your contributions to the library.