Comments (5)
i take care of it within the fix for HRes2 Mode.
from bh1750.
This is wrong, the result is still divided by 1.2 just before the return, so the returned value cannot be greater than 54612, so we cannot check for error. Also, 65535 is a valid light measurement.
I think, you should use a int32_t so that you can return -1 for error.
Another problem in this function, is that you don't check the return value of Wire.requestFrom. With multiple I2C devices, the actual code will read 2 bytes if available, no matter which I2C device they originate from. This means, if this sensor fail (when disconnected from the breadboard, for example), the actual code will read 2 bytes of another device and the return value will be randomized and look valid, when it should return -1 (or 65535, whatever you decide). You should change the code to something like
if ( Wire.requestFrom(BH1750_I2CADDR, 2) == 2 )
{
level = __wire_read();
level <<= 8;
level |= __wire_read();
}
Similarly, you should also check the result of wire.write().
Another suggestion, add a bool parameter: readLightLevel( bool raw ), which return raw value if bool is true.
Edit: Sorry I wanted to post in #26
I have other suggestions, but I think I will just write my own library... :)
from bh1750.
+1 for the suggestion that we extend the library to return a raw value
In general we should decide between int32_t or float as this library get used on embedded systems which usually are bad at float calculation. Therefore we could implement a #ifdefine
similiar to the debug setting where the user can decide between int32_t or float usage
the Wire.write()
does not return any useful information and we already check the Wire.endTransmission() return value
@guillaume57 or you fork and send pull requests ;-)
from bh1750.
+1 @coelner's suggestion sounds like a great idea
from bh1750.
#46 updated readme to reflect the range float values being returned.
from bh1750.
Related Issues (20)
- Usage information MTreg HOT 3
- add this library to Arduino Library Manager HOT 13
- Hello, the library dont really want to work with my esp32s, anyone? HOT 52
- Lower bits of MTreg HOT 5
- Issue calling readLightLevel immediately after setMTReg HOT 5
- [BH1750] Set address _after_ constructor HOT 1
- Frequent calls to readLightLevel prevents measurement update HOT 2
- [BH1750] Device is not configured! ESP8266 afterESP.deepSleep HOT 4
- Trouble using 2 sensors HOT 3
- The library works for STM32 HOT 2
- [TIP] Device not configured - temporary fix. HOT 5
- BH1750 does not work on ESP32 HOT 3
- BH1750 MTreg min is 31 in the datasheet, HOT 2
- Debug messages can cause the MCU stuck HOT 1
- 'Wire1' was not declared in this scope; did you mean 'Wire'? HOT 1
- BH1750 readLightLevel() eventually returns 27k value in low light environment HOT 1
- Possible arithmetic error evident with larger MTreg
- delete
- clarification on executing next OneTime measurment and getting delay time HOT 2
- Arduino Uno R4 minima HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bh1750.