GithubHelp home page GithubHelp logo

Make Register Access Consistent about cosmic HOT 4 CLOSED

clbx avatar clbx commented on August 16, 2024
Make Register Access Consistent

from cosmic.

Comments (4)

clbx avatar clbx commented on August 16, 2024

The given example is wrong. The issue is actually between two MOV functions.

from cosmic.

clbx avatar clbx commented on August 16, 2024

0x39 and 0x33 use registers differently

from cosmic.

clbx avatar clbx commented on August 16, 2024

Should check the following

Cosmic/src/cosproc.cpp

Lines 353 to 362 in 4c5f7c7

/* 0x17 ADDXR */
void cosproc::ADDXR(uint16_t src){
uint16_t data;
if(src % 2 == 0){
data = ((r[src] << 8) | r[src+1]);
}else{
data = ((r[src-1] << 8) | r[src]);
}

And all similar uses

Cosmic/src/cosproc.cpp

Lines 728 to 732 in 4c5f7c7

void cosproc::MOVXAR(uint16_t src){
uint16_t dst = ((Read(pc+2) << 8 | Read(pc+3))); //Get the 16bit destination
Write(dst, r[src]);
Write(dst+1, r[src+1]);
}

and all similar uses

from cosmic.

CarmanK avatar CarmanK commented on August 16, 2024

Fixed

from cosmic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.