Validation failing on valid curation about curated-data

[capfei]

@nellshamrell Also, THANK YOU for adding this feature! It can be very frustrating trying to figure out why validation fails. 🎉

[nellshamrell]

Hello @ariel11 and @capfei!

I was pulled into some other things this week, but want you to know that I will be doing a full investigation into this (as well as other validation errors) next week. Thank you for your patience!

[capfei]

@nellshamrell Can you take a look at these?

[ariel11]

Also,
PolyForm-Noncommercial-1.0.0 - #10670

[nellshamrell]

Thank you! Will take a look this week!

[nellshamrell]

@capfei @ariel11 I think what's going on here is the validation has been fixed, but these pull requests were opened before the validation was fixed.

Usually I would suggest closing and re-opening the pull request, but for some reason it's not re-running when we close and re-open the pull request (it should be doing that). Troubleshooting that to see if I can fix this.

[nellshamrell]

This appears to be an issue on the ClearlyDefined end - working on a solution to 1) Re-run the check when the PR is re-opened and 2) Give you more information when the check fails

[ariel11]

@nellshamrell - here's another one: #10937 and #10938

[nellshamrell]

Deployed a change so that when we close and re-open the pull request, it runs the validation again.

This cleared the errors on:
#10154
#10065

The others are still showing errors - working on getting you some more detailed information on those errors.

[nellshamrell]

PR's that are still showing validation errors:

#10499
#10380
#10067
#10364
#10486
#10483
#10937
#10938

[ariel11]

And #10851

[nellshamrell]

Hi @ariel11 and @capfei! I've deployed a change so that, when the validator returns an error, it opens a comment on the pull request with details of the error.

I've closed and re-opened all pull requests on this list, which triggered a comment which stated what error the validator found. Could you take a look and let me know if the errors look legitimate? And, if not, could you add a comment here pointing to the PR? This way we can consolidate the conversation to this issue, which will make it much easier to follow.

I imagine we will need to do some more tuning of the bot on what is an is not SPDX-compliant.

[capfei]

@nellshamrell These should all be compliant.
#10499 (comment)
#10486 (comment)
#10380 (comment)
#10851 (comment)
#10364 (comment)

[nellshamrell]

Hello @ariel11 and @capfei!

I've deployed some updates to the spdx libraries we use. These now pass validation!

#10499
#10486
#10364

These ones are still not working, will be investigating further:

#10380
#10851

[capfei]

Adding this one: #12293.

Validation error message:

[object Object]
[object Object]

[johnbatty]

Another similar validation issue with this PR: #12889

Validation error message:

2.6.0 licensed.declared with value "MPL-2.0 OR MIT OR Apache-2.0" is not SPDX compliant
2.5.0 licensed.declared with value "MPL-2.0 OR MIT OR Apache-2.0" is not SPDX compliant
2.4.0 licensed.declared with value "MPL-2.0 OR MIT OR Apache-2.0" is not SPDX compliant
...etc