Comments (2)
There may be a few more moving parts to this kind of change.
It's pretty common to name files to be consistent with the name of the (main) class they contain, and I think this kind of consistency (file name and class name) is significantly more important than removing a little redundancy in file names. Indeed, some languages actually enforce this kind of rule on class and file names.
We can remove the redundancy in the file names, but in that case I think we need to make better use of namespaces so that the file gadgetlib1/pairing/mnt/pairing_params.hpp
contains the class libsnark::gadgetlib1::pairing::mnt::pairing_params
, and not a class called mnt_pairing_params
.
Also related to #29 (comment)
from libsnark.
Yes this is a good point you're making here @dtebbs
I would be keen to think more about using namespaces in the various code bases. There is room for better code organization and separation here as we mostly use a single "holdall" namespace so far. I mean, the main namespaces are lib<name>
and test
as far as I remember. We use an internal
namespace at one point in Zeth, but we generally do not have a very refined way of exposing the code in our cpp libraries. There may be an argument to change that down the road and use more layers of namespaces.
from libsnark.
Related Issues (20)
- Test simple Plonk circuit on all curves
- Anemoi circuit to run all rounds
- Anemoi: NumStateColumns static parameter
- Test simple Plonk circuit on Edwards and BN128 curves
- AnemoiJive R1CS gadget
- AnemoiSponge R1CS gadget
- Plonk transcript_hasher implementation with SHA3, BLAKE, etc.
- Anemoi: small issues
- Plonk: tests with real values
- Anemoi: parameters struct for all curves of interest
- Plonk: compute srs from matrix and permutation (depends on #86, #87, #88, #89)
- Plonk: add public input indices to the srs
- Plonk: hard-code constants k1, k2 in plonk_srs_derive_from_usrs
- Plonk: update inputs to plonk_srs_derive_from_usrs(usrs, matrix, perm, pi_indices)
- Plonk: helper function plonk_prepare_matrix to build gates matrix HOT 1
- Plonk: setting k1 and k2
- Faster compuation of permutation polynomials
- Plonk circuit builder interface
- Anemoi: single anemoi pemutation round gadget
- Why to build your own library? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsnark.