Comments (6)
Thanks for raising this @kaxxa123, and for the code snippet. I guess that gadget has not been used for a while and needs some attention (and a test). Feel free to submit a pull request with your fix.
from zeth.
Thanks @kaxxa123! Good catch, the function signature is not satisfied indeed justifying the compilation error.
Rather than quick fixing this and add ZERO back, we should probably bring the sha256 hasher interface in sync with the blake one (which doesn't use ZERO), see:
zeth/libzeth/circuits/blake2s/blake2s.hpp
Lines 149 to 153 in 8247fc3
Removing ZERO from the arguments of the sha constructor begs for a refactoring of this "legacy" function that uses ONE and ZERO. So we need to get rid of the useless directives at the top of the file and use FieldT::one(), FieldT::zero() apropriately here:
zeth/libzeth/circuits/circuit_utils.tcc
Lines 51 to 64 in 8247fc3
In fact, we should probably use the bits
class here and the associated method:
Lines 107 to 119 in 8247fc3
pb_variable_array
, effectively removing this legacy code that turns out to trigger compilation error.
Let us know if you want to contribute to the project and get a shot at fixing this ticket (if not, no worries at all, we'll close this ticket on our end :) )
from zeth.
In that case I will leave the fix to you, since for the moment I am still learning about your various gadgets as I work on my dissertation :)
from zeth.
Yes, at some point the code needs to be updated to avoid the ONE and ZERO variables. Happy to do this as a separate change if you did want to submit a PR @kaxxa123. Otherwise we'll keep this issue as a reminder to do it all at once. Either way, thanks again.
from zeth.
In that case I will leave the fix to you, since for the moment I am still learning about your various gadgets as I work on my dissertation :)
No problem! We'll fix this on our end :)
from zeth.
This issue was fixed in #391, closing the ticket as a consequence.
from zeth.
Related Issues (20)
- Optimization of batch insertion and related Merkle tree update
- Consider using `pre-commit` as a tool to setup pre-commit hooks
- Consider updating exponents and round values for MiMC HOT 3
- Explicit solc install required for client docker image
- Extend tooling suite to run on Python code for better code quality and consistency HOT 1
- Upgrade to latest web3.py HOT 1
- Use explicit scopes and access specifiers and use minimal scopes by default HOT 1
- Fix docker build of the mpc image on `develop` HOT 1
- Use codespell at part of the tools ran in the CI jobs HOT 1
- Enable Zeth tx caching and GWEI target in Wallet CLI HOT 1
- Clean up ganache build and usage in this repo HOT 1
- codeql-py-build-linux CI job failing HOT 1
- Factorize configuration files across projects HOT 1
- Remove redundancy in filenames HOT 1
- Better expose prover_server (generic) util functions HOT 1
- Refactor build system dependencies to follow PEP-518 HOT 1
- zeth sync leads to ValueError HOT 1
- CI failing
- Clean up zeth CI HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zeth.