GithubHelp home page GithubHelp logo

Comments (5)

LekoArts avatar LekoArts commented on May 27, 2024

Thanks for the issue! I can reproduce it locally and will work on a fix 👍

from javascript.

LekoArts avatar LekoArts commented on May 27, 2024

Ok, so I pushed 5546a3c - the gist of it is:

One needs to use **/public/** to correctly ignore the folder. I looked at the docs of the library we're using a bit but it wasn't immediately clear to me how to "fix" this (to allow public/**).

I tried https://github.com/mrmlnc/fast-glob#basenamematch but that didn't work 🤷 Prepending **/ to everything a user enters feels dangerous as it might result in unexpected behavior.

My change isn't released yet, once that's done I'll close this

from javascript.

LekoArts avatar LekoArts commented on May 27, 2024

The fix is published now 👍

from javascript.

tmcw avatar tmcw commented on May 27, 2024

At least in v1.0.6, it doesn't appear that this fix works:

CleanShot.2024-05-20.at.16.19.45.mp4

from javascript.

BRKalow avatar BRKalow commented on May 27, 2024

Hey @tmcw 👋 Can you try specifying **/public/** instead?

from javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.