GithubHelp home page GithubHelp logo

Comments (8)

PatrikLundell avatar PatrikLundell commented on July 24, 2024

I assume you mean June, not July, as that date hasn't been reached yet...

from cataclysm-dda.

Void-Seeker avatar Void-Seeker commented on July 24, 2024

Yeah, of course it's June. Sorry for a typo.

from cataclysm-dda.

andrei8l avatar andrei8l commented on July 24, 2024

/confirmed
Include order changed for some reason so the SDL library we need isn't picked up anymore. Maybe this can fix it

diff --git a/Makefile b/Makefile
index 0dd15eb9fb..fbcaff729b 100644
--- a/Makefile
+++ b/Makefile
@@ -778,7 +778,8 @@ ifeq ($(TILES), 1)
       endif
     endif
   else ifneq ($(NATIVE),emscripten)
-    CXXFLAGS += $(shell $(PKG_CONFIG) --cflags sdl2 SDL2_image SDL2_ttf)
+    CXXFLAGS += $(shell $(PKG_CONFIG) --cflags sdl2)
+    CXXFLAGS += $(shell $(PKG_CONFIG) --cflags SDL2_image SDL2_ttf)
 
     ifeq ($(STATIC), 1)
       LDFLAGS += $(shell $(PKG_CONFIG) sdl2 --static --libs)

EDIT: it needs a bit more (workflow run)

from cataclysm-dda.

Cupidatis avatar Cupidatis commented on July 24, 2024

Same with Android builds, #74841 didn't help.

from cataclysm-dda.

harakka avatar harakka commented on July 24, 2024

Tested andrei8l's proposed solution, didn't work. I looked into this for a bit but couldn't figure out what has changed to break this. First I thought it was related to ubuntu-latest build image moving to a new release but we specifically use 20.4 for the release build, so not that either.

from cataclysm-dda.

andrei8l avatar andrei8l commented on July 24, 2024

It worked for me here; it just needed a bit more work. If that's too invasive, you can try overwriting the system SDL lib with the one we want

Untested
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 3d00a0b20c..fe19417959 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -219,17 +219,16 @@ jobs:
         if: runner.os == 'Linux' && matrix.mxe == 'none' && matrix.android == 'none' && !matrix.wasm
         run: |
           sudo apt-get update
-          sudo apt-get install libsdl2-dev
+          sudo apt-get install libsdl2-dev libncursesw5-dev libsdl2-ttf-dev libsdl2-image-dev \
+            libsdl2-mixer-dev libpulse-dev ccache gettext parallel
           git clone https://github.com/libsdl-org/SDL.git --branch release-2.0.20 --depth 1
           cd SDL
           mkdir build
           cd build
-          ../configure
+          ../configure --prefix=/usr
           make -j$((`nproc`+0))
           sudo make install
           cp ../LICENSE.txt ${{ github.workspace }}/LICENSE-SDL.txt
-          sudo apt-get install libncursesw5-dev libsdl2-ttf-dev libsdl2-image-dev \
-            libsdl2-mixer-dev libpulse-dev ccache gettext parallel
       - name: Install Emscripten (WebAssembly)
         if: matrix.wasm
         uses: mymindstorm/setup-emsdk@v13

from cataclysm-dda.

ingles98 avatar ingles98 commented on July 24, 2024

Does anyone have a fork with working Linux x64 builds?

EDIT: I just realized that in-between i was playing CDDA and sleeping this was already fixed and successfully merged. I had this issue open in a tab since yesterday and didn't see it was already closed.

from cataclysm-dda.

NetSysFire avatar NetSysFire commented on July 24, 2024

If builds are broken again, you can always compile it yourself, although it takes quite a long time (which I experienced just yesterday). Even if you are not on Arch, you have working build instructions with this PKGBUILD: https://aur.archlinux.org/packages/cataclysm-dda-git

from cataclysm-dda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.