ClickHouse Zookeeper API automatically optimize `multi` to `mutiRead` about clickhouse

[antonio2368]

If you try to use multiRead with ZooKeeper, it will not work in any case.
What should we return for isFeatureEnabled(KeeperFeatureFlag::MULTI_READ) == false?

[canhld94]

If you try to use multiRead with ZooKeeper, it will not work in any case.
What should we return for isFeatureEnabled(KeeperFeatureFlag::MULTI_READ) == false?

So you mean we can have multi with ZooKeeper, but if all operations in the request are READ then ZooKeeper will not work?

I see multi is used in many places for replicated merge tree, and it should work with both ZooKeeper and Keeper.

[antonio2368]

@canhld94 yes, but multi is used with Write requests only in ReplicatedMergeTree and all features available.
If someone uses multi with READ requests without checking if it's supported, it's a bug.
A generic options are function overloads accepting vector of paths, e.g. get(std::vector<std::string> paths) which will correctly fallback to separate requests if MultiRead is not supported.

[canhld94]

@canhld94 yes, but multi is used with Write requests only in ReplicatedMergeTree and all features available.
If someone uses multi with READ requests without checking if it's supported, it's a bug.
A generic options are function overloads accepting vector of paths, e.g. get(std::vector<std::string> paths) which will correctly fallback to separate requests if MultiRead is not supported.

I see, thanks for explaining!