Comments (5)
As a contributor, I second that more feedback would be helpful. It seemed that my PR #33 was on track to be merged, but it has been in limbo for a while even if the PR would remove a bottleneck for using hickory dependents on Node.
from hickory.
Yeah, Maybe you're right. My feeling has always been that they're there if the original requester wants to pick it back up, or if someone else wants to come along and do the work.
from hickory.
or if someone else wants to come along and do the work.
I'd say that's a reasonable expectation if it's an issue, but for a PR, either it's merged or it isn't. If someone's considering submitting a new one, and they see PRs open from 2014 in 2016, it gives the impression the project's not following up.
How about adding a note to see if the submitter wants to bring them up to speed, and otherwise just close them after X time of radio silence? Might not even be clear to the submitter what the requirements for acceptance are.
from hickory.
100% agree with the sentiment, will work on it
from hickory.
Not sure how to proceed with #35, but it's plausible enough to leave open
from hickory.
Related Issues (20)
- Parsing throws on long markdown files HOT 1
- very odd interactive issue HOT 1
- event handlers HOT 2
- Unexpected conversion result HOT 3
- StackOverflowError when parsing many unclosed tags in series HOT 8
- Hickory does not correctly parse <noscript> tags in <head> HOT 1
- License Issue with codox - GPLv3 vs EPL HOT 3
- (as-hiccup (parse-fragment ...)) doesn't work in clojurescript with shadow-cljs HOT 2
- Node.js support revisited HOT 2
- :viewBox property in svg not correctly parsed to hiccup. HOT 2
- svg tag viewBox becomes viewbox HOT 1
- Invalid output by as-hiccup HOT 2
- Link to API documentation are broken - 404 not found
- Any interest in CSS-style selectors? HOT 3
- Graal doesn't compile for 0.7.2+ HOT 3
- After bundling hickory in an uberjar, it throws and exception when running that .jar file HOT 2
- Select all between two things? HOT 1
- `find-in-text` selector does not seem to work when it's the last argument of a `child` selector
- Use of aget breaks under advanced compilation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hickory.