Command to 'in-ns' into current buffer namespace about cider

[technomancy]

I found a few places (nrepl-interactive-eval and friends) that were checking nrepl-buffer-ns which was incorrectly set to "user"; replacing those references with a call to (nrepl-current-ns) fixed the problem, but I'm not sure if it's the correct solution; it's probably better to just ensure nrepl-buffer-ns is set correctly.

[jsnikeris]

If you add (setq nrepl-buffer-ns (nrepl-current-ns)) to nrepl-interaction-mode's definition, the namespace will be set correctly when you open an existing Clojure file.

However, I think we ought to do away with nrepl-buffer-ns altogether. The difficulty of correctly maintaining its state is not worth the benefit. Because nrepl-current-ns uses it as an optimization to prevent a call to clojure-find-ns, if you change the current buffer's namespace, even nrepl-current-ns will return an incorrect value.

[technomancy]

Yeah, makes sense to me.

[jsnikeris]

This is trickier than I thought.

nrepl-buffer-ns is sent to the nREPL server for the interactive-eval calls. Simply replacing it with a call to nrepl-current-ns will cause a NPE on the server side if the namespace has not yet been defined.

[jsnikeris]

The above pull request adds the functionality requested by Alexander.

I've come to accept that it makes sense to have an nrepl-buffer-ns variable. SLIME uses a similar variable. However, it is confusing to have both a variable and a function that are named similarly that serve slightly different purposes.

[kingtim]

Good point, probably nrepl-current-ns should be renamed.