GithubHelp home page GithubHelp logo

A better logging approach about gizmo HOT 5 CLOSED

clojurewerkz avatar clojurewerkz commented on July 17, 2024
A better logging approach

from gizmo.

Comments (5)

ifesdjeen avatar ifesdjeen commented on July 17, 2024

I would say that testing logging is not really necessary.
It's enough to just make it work fine.

Seems that for gizmo-web-template we only need to provide a new release. I'll do that as soon as we have a stable working version.

from gizmo.

ujh avatar ujh commented on July 17, 2024

I finally had some time to look at this again. Changing the code in loggin.clj to use timbre was no problem. Unfortunately just adding the dependency to project.clj in gizmo didn't work (leiningen couldn't find timbre). So I had to add it to gizmo-cloc and gizmo-web-template, too.

gizmo commits: https://github.com/ujh/gizmo/commits/feature/logging
gizmo-cloc commit: ujh/gizmo-cloc@dc1f9955e9591223d9a7596c2f01a0540692648f
gizmo-web-template commit: ujh/gizmo-web-template@6e88c818e74460a61faf23b7a96c597df4dc441e

This of course is only the minimal solution. Should I have a look at the timbre configuration options and if it's possible to configure the logging in the environment? Just like jetty is configured in development.clj? The fact that timbre is essentially configured through a global system (@timbre/config, timbre/set-level!, ...) isn't very encouraging though.

from gizmo.

ifesdjeen avatar ifesdjeen commented on July 17, 2024

Oh my, somehow I completely missed your commits :/

from gizmo.

ujh avatar ujh commented on July 17, 2024

Not to worry Alex, I've been swamped with work right after finishing this anyway.

from gizmo.

ifesdjeen avatar ifesdjeen commented on July 17, 2024

Merged!

from gizmo.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.