GithubHelp home page GithubHelp logo

Comments (8)

kapilt avatar kapilt commented on May 24, 2024

I think the issue is on the custodian side, in that we need to ensure read only properties are not in the patch document, I've put up a pull request (#9297) that should address

also noting the awscc provider is relatively new, most custodian usage is using the aws.

from cloud-custodian.

kapilt avatar kapilt commented on May 24, 2024

you would also typically want to do a single update invocation across all properties to change.

from cloud-custodian.

snowiow avatar snowiow commented on May 24, 2024

you would also typically want to do a single update invocation across all properties to change.

ah yes, I was doing that in my first attempt. That snippet was a later one, where I tried things out, because I was not 100% sure what to change from the workaround the aws support send me for the case I described in the end 😄

And thanks a lot for handling this so quickly, really appreciate it 🙏

from cloud-custodian.

kapilt avatar kapilt commented on May 24, 2024

yeah.. we only do full replacement atm the listed attributes instead of doing partial update which is really what your looking for here, investigating what partial would take.

from cloud-custodian.

kapilt avatar kapilt commented on May 24, 2024

I've been thinking about how best to do partial update, and it does feel like the simplest thing here is to in addition of support key/value replacement, also support a user specified patch notion.

     - type: update
       patch: 
         - op: add
           path: WorkGroupConfiguration/EnforceWorkGroupConfiguration
           value: true
         - op: add
           path: WorkGroupConfiguration/ResultConfiguration/EncryptionConfiguration/EncryptionOption
           value: SSE_S3

from cloud-custodian.

snowiow avatar snowiow commented on May 24, 2024

Hi, yes that sounds great. With that you would also have the possibility to do the original cloudcontrol operation directly from cloudcustodian 👍

from cloud-custodian.

kapilt avatar kapilt commented on May 24, 2024

patch functionality added fwiw

from cloud-custodian.

snowiow avatar snowiow commented on May 24, 2024

Thank you 🙏 Can you already tell, when the next release will happen?

from cloud-custodian.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.