cannot login when enable auth backend as desktop.auth.backend.AllowAllBackend about hue

[CrystalCat]

hi~
trace login process. it turns out it may be hue's AllowAllBackend not implements Django3.x auth backend implementation.

in build/env/lib/python3.8/site-packages/django/contrib/auth/init.py
line 64~74

def authenticate(request=None, **credentials):
    """
    If the given credentials are valid, return a User object.
    """
    for backend, backend_path in _get_backends(return_tuples=True):
        backend_signature = inspect.signature(backend.authenticate)
        try:
            backend_signature.bind(request, **credentials)
        except TypeError as e:
            # This backend doesn't accept these credentials as arguments. Try the next one.
            raise e

it called by build/env/lib/python3.8/site-packages/django/contrib/auth/forms.py line 202

self.user_cache = authenticate(self.request, username=username, password=password)

AllowAllBackend.authenticate(username,password) inhers from DesktopBackendBase only accept 2 arguments.

##  desktop/core/src/desktop/auth/backend.py

class DesktopBackendBase(object):
  """
  Abstract base class for providing external authentication schemes.

  Extend this class and implement check_auth
  """
  def authenticate(self, username, password):
    if self.check_auth(username, password):
      user = find_or_create_user(username)
      user = rewrite_user(user)
      return user
    else:
      return None

it will raise error TypeError("multiple values for argument 'username'") while invoke backend_signature.bind(request, **credentials) , DesktopBackendBase. authenticate method need some change to play with Django3.x

[bjornalm]

@CrystalCat thanks for your detailed bug report. Since Hue is open source and the core team has limited time on their hands, would you be interested in creating a PR for this so that they could have a look?

[CrystalCat]

@bjornalm thanks,I'll try to create a PR for this problem. closing