FetchEvent constructor no longer accepts second argument about workers-types

[vlovich]

I think this is a compliance issue in the runtime itself & not an issue with the types. We actually don't support constructing a FetchEvent & the exposition of the constructor at all is an oversight in the typing. The next release will remove the FetchEvent constructor until it's actually available in the Runtime.

[lookfirst]

It was complaining at first, but clearing the cache and restarting the project cleared that up. We have success! Thanks for your patience.

[dferber90]

I'll close this as I understand that FetchEvent was not exposed on purpose and this issue is thus irrelevant. Thanks for clarifying!

As a wacky solution for my specific issue, I found that using /// <reference lib="webworker" /> in my test files solves it for now. There's probably a much cleaner solution, but who's got the time eh

[lookfirst]

@vlovich You might not support constructing a FetchEvent, but it is still necessary.

addEventListener('fetch', (event: any) => {
	event.respondWith(router.handle(event.request));
});

That is ugly.

[mrbbot]

Hey! 👋 FetchEvent is still included in the typings (just without the constructor), so you can still do:

addEventListener('fetch', (event: FetchEvent) => {
  event.respondWith(router.handle(event.request));
});

Additionally, when using the global addEventListener, the type of event is inferred for fetch and scheduled events, so you can actually omit FetchEvent:

addEventListener('fetch', (event) => {
  // event is automatically typed FetchEvent
  event.respondWith(router.handle(event.request));
});

[lookfirst]

@mrbbot I see it in there, but it doesn't show up in IDEA for some reason... thoughts?

"@cloudflare/workers-types": "^3.2.0",

[lookfirst]

Also:

[mrbbot]

@lookfirst You have dom in the compilerOptions.lib array. @cloudflare/workers-types conflicts with this so you'll need to remove dom from that list.

If you've also got a front-end web app in the same project, you may want to add a separate tsconfig.json that extends this root one in the front-end's directory:

// e.g. web/tsconfig.json
{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "lib": ["esnext", "dom"],
    "types": []
  }
}

[lookfirst]

@mrbbot Thanks. I was getting errors without "dom" in there before, but it seems like that is magically gone now. That said, FE still isn't showing up... it is part of miniflare?

I do not have a web project at all, it is just a worker.

[mrbbot]

FetchEvent is included in miniflare, but it's also included in workers-types so you shouldn't need to import it. If you just write FetchEvent there (without importing anything), does IDEA complain? Have you tried restarting the TypeScript language service?