GithubHelp home page GithubHelp logo

Comments (3)

lukeed avatar lukeed commented on August 15, 2024

These are not the same thing. The WebSocketPair returns an object with 0 and 1 keys, not an array with two items. That's why pair[0] and pair[1] still work

from workers-types.

CodeWitchBella avatar CodeWitchBella commented on August 15, 2024

Thanks for the quick response

That makes sense, and it indeed does crash when I try to destructure it directly. I see that docs use Object.values as a workaround, which is good enough.

Would it make sense to add something like (works in miniflare)

WebSocketPair.prototype[Symbol.iterator] = function* () {
  yield this[0];
  yield this[1];
};

to support direct destructuring? But this would probably go as a feature request on another repo :-) Feel free to close this.

from workers-types.

vlovich avatar vlovich commented on August 15, 2024

CC @jasnell for visibility.

from workers-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.