Comments (2)
Idea is to surround the branch inclusion patterns by ^...$ to get a full branch name match.
#581 will test this on https://github.com/cloudfoundry/branchprotection-test. Once merged, I will create test branches similar to the ones listed above which should not be touched anymore. If it works as expected, I adapt the org automation.
from community.
Test #581 succeeded. I created a few test branches on repo branchprotection-test similar to the problematic ones on cf-deployment and the remained unprotected after an org automation run:
https://github.com/cloudfoundry/community/actions/runs/4694888643/jobs/8323476572
...
{"client":"github","component":"branchprotector","file":"k8s.io/test-infra/prow/github/client.go:918","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"GetRepo(cloudfoundry, branchprotection-test)","severity":"info","time":"2023-04-14T06:36:00Z"}
{"client":"github","component":"branchprotector","file":"k8s.io/test-infra/prow/github/client.go:918","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"GetBranches(cloudfoundry, branchprotection-test, false)","severity":"info","time":"2023-04-14T06:36:01Z"}
{"component":"branchprotector","file":"k8s.io/test-infra/prow/cmd/branchprotector/protect.go:329","func":"main.(*protector).UpdateRepo","level":"info","msg":"cloudfoundry/branchprotection-test=develop: not included","severity":"info","time":"2023-04-14T06:36:01Z"}
{"component":"branchprotector","file":"k8s.io/test-infra/prow/cmd/branchprotector/protect.go:329","func":"main.(*protector).UpdateRepo","level":"info","msg":"cloudfoundry/branchprotection-test=manual_merge_stemcell_update_from_main: not included","severity":"info","time":"2023-04-14T06:36:01Z"}
{"component":"branchprotector","file":"k8s.io/test-infra/prow/cmd/branchprotector/protect.go:329","func":"main.(*protector).UpdateRepo","level":"info","msg":"cloudfoundry/branchprotection-test=stephanme-patch-1: not included","severity":"info","time":"2023-04-14T06:36:01Z"}
{"component":"branchprotector","file":"k8s.io/test-infra/prow/cmd/branchprotector/protect.go:329","func":"main.(*protector).UpdateRepo","level":"info","msg":"cloudfoundry/branchprotection-test=test: not included","severity":"info","time":"2023-04-14T06:36:01Z"}
{"component":"branchprotector","file":"k8s.io/test-infra/prow/cmd/branchprotector/protect.go:329","func":"main.(*protector).UpdateRepo","level":"info","msg":"cloudfoundry/branchprotection-test=update-cf-cli-release-v1.43.0: not included","severity":"info","time":"2023-04-14T06:36:01Z"}
{"client":"github","component":"branchprotector","file":"k8s.io/test-infra/prow/github/client.go:918","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"GetBranches(cloudfoundry, branchprotection-test, true)","severity":"info","time":"2023-04-14T06:36:01Z"}
{"client":"github","component":"branchprotector","file":"k8s.io/test-infra/prow/github/client.go:918","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"GetBranchProtection(cloudfoundry, branchprotection-test, main)","severity":"info","time":"2023-04-14T06:36:01Z"}
{"client":"github","component":"branchprotector","file":"k8s.io/test-infra/prow/github/client.go:918","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"GetBranchProtection(cloudfoundry, branchprotection-test, v1)","severity":"info","time":"2023-04-14T06:36:01Z"}
{"client":"github","component":"branchprotector","file":"k8s.io/test-infra/prow/github/client.go:918","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"UpdateBranchProtection(cloudfoundry, branchprotection-test, main, {\"required_status_checks\":null,\"enforce_admins\":true,\"required_pull_request_reviews\":{\"dismissal_restrictions\":{},\"dismiss_stale_reviews\":true,\"require_code_owner_reviews\":true,\"required_approving_review_count\":1,\"bypass_pull_request_allowances\":{\"users\":[],\"teams\":[\"wg-app-runtime-deployments-bots\"]}},\"restrictions\":null,\"required_linear_history\":false,\"allow_force_pushes\":false,\"allow_deletions\":false})","severity":"info","time":"2023-04-14T06:36:01Z"}
{"client":"github","component":"branchprotector","file":"k8s.io/test-infra/prow/github/client.go:918","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"UpdateBranchProtection(cloudfoundry, branchprotection-test, v1, {\"required_status_checks\":null,\"enforce_admins\":true,\"required_pull_request_reviews\":{\"dismissal_restrictions\":{},\"dismiss_stale_reviews\":true,\"require_code_owner_reviews\":true,\"required_approving_review_count\":1,\"bypass_pull_request_allowances\":{\"users\":[],\"teams\":[\"wg-app-runtime-deployments-bots\"]}},\"restrictions\":null,\"required_linear_history\":false,\"allow_force_pushes\":false,\"allow_deletions\":false})","severity":"info","time":"2023-04-14T06:36:01Z"}
...
I will file a PR to adapt the org automation coding to generate branch protection include patterns surrounded by ^...$.
from community.
Related Issues (20)
- Remove org members for which the invite has failed HOT 2
- Paketo Buildpacks Steering Committee Candidate Nomination for Forest Eckhardt HOT 1
- Paketo Buildpacks Steering Committee Candidate Nomination for Daniel Mikusa HOT 1
- Paketo Buildpacks Steering Committee Candidate Nomination for Jan von Löwenstein HOT 1
- TOC Candidate Nomination for Stephan Merker HOT 1
- TOC Candidate Nomination for Jesse Alford HOT 3
- TOC Candidate Nomination for Chris McGowan HOT 4
- TOC Candidate Nomination for Amelia Downs HOT 2
- Permissions for CLAW repo were lost overnight HOT 2
- Org automation fails due to missing default branch for some bosh repos HOT 1
- Github project administration for WG areas HOT 2
- Create a new repository `cloudfoundry/otel-collector-release` for ARP WG HOT 1
- Remove the Github users added as "Outside collaboration" to the cloudfoundry org HOT 2
- cloudfoundry-community org is not accessible HOT 6
- [Discussion] Future of Important Repos in the cloudfoundry-community Organisation HOT 4
- Moving repos from bosh-prometheus account to cloudfoundry account HOT 9
- deploy cassandra database as an application using cassandra.jar HOT 1
- Is it possible to run docker compose on Cloud Foundry ? HOT 1
- Is it possible to run docker compose on Cloud Foundry ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from community.