Comments (4)
Small
from drizzle.
Hey @tylersticka, could I get some clarification from you on these tasks? Maybe some screenshots?
There's too much margin above the titles at large sizes (should probably be margin below thumbs instead).
Not sure what this is describing. :)
We should override padding on labels in case a project doesn't (they are a
<ul>
currently).
This isn't clear to me either. :P
We should allow pattern titles to wrap (not sure why we aren't).
Is this referring to the <pre>
code?
Thanks!
from drizzle.
There's too much margin above the titles at large sizes (should probably be margin below thumbs instead).
Currently the page titles have margin above them. This is fine at small sizes:
But at larger sizes when the layout shifts, the upper margin looks kinda funky. This isn't super noticeable until you have a longer description, which we do in other projects:
We should override padding on labels in case a project doesn't (they are a
<ul>
currently).
The labels are inside of a <ul>
element, but we aren't overriding the list display of that element in our Drizzle CSS. But if we disable or change toolkit.css
, they get excess padding on the left:
This is because our toolkit.css
removes padding-left
from all <ul>
elements. But that's fairly uncommon in our projects, so ideally our <ul>
would have its left padding removed (perhaps with a utility class) to avoid this issue.
We should allow pattern titles to wrap (not sure why we aren't).
Is this referring to the
<pre>
code?
Nope, the pattern headings. They have a white-space: nowrap
utility on them, which means longer titles won't break at narrow widths:
@mrgerardorodriguez Responses above, let me know if you have more questions.
from drizzle.
Cool, thanks @tylersticka! 😀
from drizzle.
Related Issues (20)
- Standalone pages HOT 2
- Fresh build breaks due to outdated dependencies HOT 6
- The nav is broken HOT 2
- Use postcss-preset-env
- Make sure "e" isn't cut off on Drizzle logo
- Invalid name: "@cloudfour/hbs-helpers" HOT 5
- Unable to put new folders into pattern folder HOT 1
- Back-end Integrations HOT 18
- Notes property not working when defined via pattern collection HOT 1
- notice new/deleted files and update the browser HOT 1
- Handlebars Partial blocks don't work for Patterns HOT 12
- gracefully recover from errors in gulp chain HOT 1
- Could npm build errors get reported to the Drizzle UI somehow? HOT 1
- Adding arbitrary code samples to patterns HOT 2
- Using baseurl in patterns HOT 3
- Global variables not being complied in dist HOT 5
- Add .DS_Store to .gitignore HOT 1
- Discuss dev dependency gulp-gh-pages HOT 9
- Fix awkward size/positioning of drizzle logo in drizzle-Nav-header
- Frame-thumb max-width should be none
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drizzle.