Cannot interrupt crash commands from the main console about osv

[tgrabiec]

This issue should be solved when we switch to CRaSH with this change released: https://github.com/tgrabiec/crash/tree/interrupting

It is still experimental work and originates from upstream maintainer with intent to make interruption work also on Windows. It changes the approach for triggering interruption from having a SIGINT handler to disabling 'intr' in stty and reacting on character '\x03' (^C).

[nyh]

On Thu, Oct 10, 2013 at 10:53 AM, Tomasz Grabiec
[email protected]:

This issue should be solved when we switch to CRaSH with this change
released: https://github.com/tgrabiec/crash/tree/interrupting

It is still experimental work and originates from upstream maintainer with
intent to make interruption work also on Windows. It changes the approach
for triggering interruption from having a SIGINT handler to disabling
'intr' in stty and reacting on character '3' (^C).

Good, this is basically what the ssh code already does (it doesn't get
SIGINT, so it needs to handle '\3' on its own), so it's what Avi suggested
we do.

Please note that this will only correctly interrupt JVM-based commands
(Java, Groovy, etc.) - if we run elf commands, they won't cooperate with
the Java Thread.interrupt() protocol, and can't be stopped in this way. But
we can think about this issue another time.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/53#issuecomment-26034976
.

Nadav Har'El
[email protected]

[tgrabiec]

A new version of CRaSH (1.3.0-beta8) has just been released, it should have the necessary fixes: crashub/crash@4b70314

[penberg]

@tgrabiec What's the status of this? Did we already switch to new version Crash?

[tgrabiec]

@penberg No, we haven't yet. I talked to @lightpriest, he's going to work on upgrading.

[lightpriest]

mgmt tree is upgraded to CRaSH 1.3.0-beta8 but it has a new bug (specifically related to OSv). I sent a pull request to fix it.

[tzach]

@lightpriest any chance we can have this fix for OSv 0.0.4 ?

[lightpriest]

@tzach I tried crash-1.3.0-beta11 to test this, but now there's a new problem. ^C not only causes thread top to stop, but the vm terminates, I'll try to find out why. Any ideas in the meantime?

[lightpriest]

This patch (https://groups.google.com/forum/#!topic/osv-dev/S8pN0ODiF4Y) should make ^C work intuitively, no need to upgrade CRaSH, for now. I'll wait on the merge which enables automatic ssh host key generation.

[tzach]

works
Ctrl+C stops thread top, and return to CLI