By default, recovery_target_inclusive should be false per document about cloudnative-pg

[gbartolini]

The default behaviour in PostgreSQL is to have the inclusive target enabled by default. See https://www.postgresql.org/docs/current/runtime-config-wal.html#GUC-RECOVERY-TARGET-INCLUSIVE

I think we just need to fix the documentation as the code, IMHO, is coherent with Postgres' behaviour:

        switch {
        case target.Exclusive == nil:
                result += "recovery_target_inclusive = true\n"
        case *target.Exclusive:
                result += "recovery_target_inclusive = true\n"
        default:
                result += "recovery_target_inclusive = false\n"
        }

[jsilvela]

Agree with matching the default in Postgres.
As I read the code, I think the code is wrong though:

    case *target.Exclusive:
        result += "recovery_target_inclusive = true\n"
    default:
        result += "recovery_target_inclusive = false\n"

if target.Exclusive is TRUE, we append recovery_target_inclusive = true.
Does not look right...

One of those (many) cases where a switch's default keyword gives the wrong impression of what's going on.
The default case is when target.Exclusive is nil i.e. not provided. Rewriting with if for clarity....