Comments (5)
@bolora @lasley we have just released public and themeable design tokens for border radius. In our documentation website you can find:
- The list of border radius tokens.
- Additional implementation guidelines for theming.
from components.
Hey Bo,
thank you for reaching out. A theme-able design token for border radius on various component groups seems like a reasonable addition to the theming capabilities. However, we currently don't have any plans for making this change.
I will keep this issue open to collect any additional feedback. Feel free to share more information about your use case for theme-able border radius and how you would use it in your application.
Thank you,
Florian
from components.
Thanks for the explanation @FlorianDr. Would you accept the change in the form of a PR?
Answered my own question in the Contribution guide. No, PRs are not accepted for enhancements. How long will this be the case?
from components.
That's correct! For now, we don't accept PRs for enhancements, until we have found a good contribution model both for contributors and maintainers. Do you already have a fork/PR ready?
from components.
@FlorianDr - not at this time; I'd like to avoid effort if it won't be accepted. We're in the process of identifying whether CloudScape will work for our use case, and rounded corners was one of the reasons it wouldn't. This issue was a test of waters to understand how/if our needs could be integrated into this design system before making an adoption choice.
from components.
Related Issues (20)
- [Feature Request]: CloudWatch dashboard UI button not aligned HOT 1
- [Feature Request]: Adding Virtual Rendering to a Table Component HOT 3
- [Bug]: Build Error HOT 2
- Sint at et optio et HOT 1
- [Bug]: Date picker value format is different with show format HOT 2
- [Bug]: 'getLogicalBoundingClientRect' is not exported HOT 2
- top nav bar issue HOT 1
- Limit number of pagination pages shown when having large amount of items. HOT 1
- [Feature Request]: Time Picker HOT 1
- [Feature Request]: Hope to support Menu tabs theme customization ability HOT 3
- [Bug]: Drag and drop to upload a file does not work on macOS Safari HOT 2
- [Feature Request]: Paste to upload file HOT 3
- [Bug]: Gap between files missing on Safari HOT 1
- [Bug]: Updating selectedItems in Table component does not update HOT 1
- [Bug]: `act` from `react-dom/test-utils` is deprecated HOT 4
- [Bug]: Warning when openning and then closing dialog in tests HOT 4
- [Feature Request]: Custom button for DateRangePicker trigger node. HOT 1
- [Feature Request]: Allow year-by-year navigation in date picker HOT 3
- [Bug]: Missing "./internal/analytics-metadata" specifier in "@cloudscape-design/component-toolkit" package after upgrading from 3.0.684 HOT 2
- [Bug]: Theming and nested rules HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from components.