GithubHelp home page GithubHelp logo

Comments (9)

orius123 avatar orius123 commented on September 10, 2024

Hi,

the underscore convention comes from python,
there are people that write camelCase for variables in python but most doesn't..
so, moving to camel case will be better for Java, but since I believe most of our content will use Python personally I prefer underscores.

vote?

from cs-content.

meirwah avatar meirwah commented on September 10, 2024

i think all can agree on the underscore convention, BUT issue is what we do with inputs of the actions(which are java based)??

from cs-content.

orius123 avatar orius123 commented on September 10, 2024

why not making operations that are java based use camelCase' andPython` based use underscores?

Java op

- java_op
    inputs:
      - firstInput
      - secondInput
    ....

Python op

- python_op
    inputs:
      - first_input
      - second_input
    ....

from cs-content.

meirwah avatar meirwah commented on September 10, 2024

👍 from my prespective...

from cs-content.

oritstone avatar oritstone commented on September 10, 2024

👍

from cs-content.

tudorlesan avatar tudorlesan commented on September 10, 2024

@orius123 @meirwah @oritstone there is one problem with this approach. Let's say we have a flow that has 2 steps that have as outputs error messages and an on_failure step which sends the error message as an email. If for example the first step will be a python_op then it would have the output error_message and the other one if it's a java_op it would have the output errorMessage. That means that everytime I have to check which one is not empty and email that one. The same for returnResult.Sounds good? WDYT?

from cs-content.

oritstone avatar oritstone commented on September 10, 2024

The problem with the different conventions between python & Java actions is only relevant in the operations, and each operation should be in a separate file.
When you specify an output to the operation, you can give whatever name you want, and it should be by our lower case words convention:

- java_op
    inputs:
      - firstInput
      - secondInput
    outputs:
      - error_message: errorMessage

And then in the flow, all the tasks deal with lower case names

from cs-content.

tudorlesan avatar tudorlesan commented on September 10, 2024

👍

from cs-content.

orius123 avatar orius123 commented on September 10, 2024

feel free to close if you think it is resolved 😃

from cs-content.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.