Issue deploying web resources when using MFA about cds-for-code

[CloudSmithIra]

Hi there!

Thank you for your feedback. That interactive message is denoting that a browser is opening up outside of the vscode process and may require you to interact with it before proceeding.

It looks like you might be running into an issue with the pack command finding the webresource on disk due to the fsPath being undefined.

I'm going to run some triage on this doing the following:

1. Unpack a solution
2. Edit a webresource
3. Pack and send the edited webresource back to the server

If there's something I missed with your scenario, please let me know. Once the issue is located and resolved we can get it bundled up into our next release.

[CloudSmithIra]

Hi,

My test was able to successfully unpack the solution, edit the webresource, and then deploy it back to CDS. Did you run into an error? If so would you mind giving me a bit more information on what you were trying to do?

[sudmanche]

Hi, doing exactly what you describe.
Unpack - works fine
Edit a web resource
Deploy. You are correct here, I did not spot the fsPath error, but that seems to be the real issue, as it is authenticating after that.
Not doing anything else.

[sudmanche]

Here is a bit more log, with a little bit on anonymization.

[09:06:54]: Command: cs.cds.controls.explorer.packWebResource (Pack web resource from existing file) invoked with: {"0":{"scheme":"file","authority":"","path":"/c:/CodeDAM/SIM/Solution/WebResources/WebResource.js","query":"","fragment":"","_formatted":"file:///c%3A/CodeDAM/SIM/Solution/WebResources/WebResource.js","_fsPath":"c:\CodeDAM\SIM\Solution\WebResources\WebResource.js"},"1":{"0":{"$mid":1,"fsPath":"c:\CodeDAM\SIM\Solution\WebResources\WebResource.js","_sep":1,"external":"file:///c%3A/CodeDAM/SIM/Solution/WebResources/WebResource.js","path":"/c:/CodeDAM/SIM/Solution/WebResources/WebResource.js","scheme":"file"}}}
[09:06:54]: Command: cs.cds.deployment.packWebResource (Pack web resource) invoked with: {"3":{"scheme":"file","authority":"","path":"/c:/CodeDAM/SIM/Solution/WebResources/WebResource.js","query":"","fragment":"","_formatted":"file:///c%3A/CodeDAM/SIM/Solution/WebResources/WebResource.js","_fsPath":"c:\CodeDAM\SIM\Solution\WebResources\WebResource.js"}}
[09:06:54]: Command: cs.cds.deployment.packWebResource invocation complete
[09:06:54]: Command: cs.cds.controls.explorer.packWebResource error occurred: Cannot read property 'fsPath' of undefined
[09:06:54]: Command: cs.cds.controls.explorer.packWebResource invocation complete
[09:06:54]: OAuth: removing existing token and attempting re-authentication flow.
[09:06:54]: OAuth: Refresh token found, invoking call to acquire auth token
[09:06:54]: OAuth: HTTP 401 received
[09:06:57]: OAuth: Multi-factor authentication (MFA) required, starting browser request
[09:06:57]: Browser: http://localhost:3999/auth opened by 'opn'
[09:07:00]: OAuth: Multi-factor authentication (MFA) completed and authorization code received
[09:07:04]: OAuth: Auth code converted to token successfully
[09:07:04]: HTTP GET https://globaldisco.crm.dynamics.com/api/discovery/v2.0/Instances (statusCode: 200, out: 0b, in: 6236b, time: 76ms)
[09:07:04]: OAuth: removing existing token and attempting re-authentication flow.
[09:07:04]: OAuth: Refresh token found, invoking call to acquire auth token
[09:07:04]: OAuth: HTTP 401 received
[09:07:07]: OAuth: Multi-factor authentication (MFA) required, starting browser request
[09:07:07]: Browser: http://localhost:3999/auth opened by 'opn'
[09:07:09]: OAuth: Multi-factor authentication (MFA) completed and authorization code received
[09:07:10]: OAuth: Auth code converted to token successfully

[CloudSmithIra]

Hi there,

I spotted the line causing the error in the log. It's located here:

cds-for-code/src/components/Solutions/WebResourceManager.ts

Line 39 in aca7b4b

await Quickly.openFile(returnObject.fsPath);

I've introduced some handling for it which will come in our next release this week.

Can you verify that the file changes didn't make it back to the server? If so I might need some deeper triage here. That fsPath undefined error only happens after the pack command has been run. This part of the log shows it completing:
[09:06:54]: Command: cs.cds.deployment.packWebResource invocation complete

[sudmanche]

I can confirm the web resource was not updated in CDS.
Thanks for the help.

[CloudSmithIra]

Hi @sudmanche,

Thanks for confirming that for me. We plan to have another release out by the end of this week that addresses the fsPath undefined issue, although I can't be positive this will fix the issue you've encountered. We can wait and see if this is the case, or alternatively if you're open to it we can setup a screensharing meeting to do the following:

1. Get the code cloned to your computer
2. Get your debug build up and running
3. Replicate your scenario while adding some breakpoints

If this is something that we can do for you please send us an email at [email protected] in reference to this GitHub issue and we will happily arrange a time for this.

Regards,
Ira

[CloudSmithIra]

The changes mentioned went into today's release. You should be able to update the extension for the latest bits. If you still continue to experience the problem, please let me know.

[CloudSmithIra]

Hi @sudmanche ,

Please let us know if the fixes in release 0.8.13 were able to remediate your problem. If so, I will mark this issue as closed. In the case that it doesn't we're happy to setup a remote debug session to help pinpoint the problem.

[sudmanche]

Hi, I have been testing this again. Results are mixed.
Initially I could still see that _fsPath was null. I dug around a bit and found that this is because I was just opening a folder, and not a workspace. So I saved a workspace, that seemed to fix that issue.

So then in 10 or more attempts to deploy a web resource, I managed to get it to work just once.
Most often it seems the issue if the MFA pop up window, either it never opens, or when it closes the tool seems not to get the response. This is true of various operations, such as export & unpack.

Once any sort of issue has been encountered, you can guarantee nothing will work without a restart of vscode.

In general, I am having even more issues with this release than the last one. It seems less stable.
I realise this is early preview, so that is understandable. I will try it again once the 0.9 release is ready.

[CloudSmithIra]

I'm wondering if this might be some sort of pop up blocker, an issue with the opn library, or even a timing issue with the token exchange? As a first step you might try looking at your browser's pop up configuration.

Unfortunately, we don't have any planned changes to the auth for the 0.9.0 release at the moment. I can work on reproducing this internally if you have any other information about how your AD account is setup (MFA, target region, etc...), or alternatively we can try a screen share support session at a coordinated time if you're up for that.