Comments (5)
Oh, then, it is clear that AdamP
causes the problem.
I'm sorry but, it is really hard to figure out the reason for cpu
issue.
I have read the code multiple times. Everything looks just fine.
I'm suspicious of the built-in cosine functionF.cosine_similarity
.
You can try an old version of AdamP
(https://github.com/clovaai/AdamP/blob/v0.2.0/adamp/adamp.py) to verify the built-in cosine function.
If the old version has the same problem, I have no idea what is causing the problem.
from adamp.
Thank you for your valuable comments 👍
I will fix it when I find a clue for the problem.
from adamp.
Hi
I haven't tried AdamP
on cpu. Most of the experiments are conducted on GPU environments.
So, I'm not 100% sure, but, I believe our implementation can work on cpu.
BecauseAdamP
consists of simple operations which has no dependency on cuda.
I think other parts of the training code might cause the problem.
I recommend you to test other optimizers such as Adam
or AdamW
.
If other optimizers work normally on the CPU, I will try to figure out the cause of the problem.
from adamp.
Hi, Thanks for the reply.
I already checked the code on cpu with Adam
and other optimizers in torch.optim
. All of them work properly on both devices; cuda and cpu. FYI, the machine that I used for the experiments equips a Ryzen 2990wx and two Nvidia RTX titans.
BTW, AdamP
results in better training outcomes than Adam
on cuda. Cheers Adamp
.
from adamp.
oh actually I'm fine w/ the current version of AdamP
because I still can run the codes on cuda. Thanks for the comments :)
I raise an issue because it might be helpful to the contributors/maintainers to notice this 'maybe-issue' problem.
from adamp.
Related Issues (13)
- Hyperparameters of AdamW HOT 7
- example params HOT 2
- Could it be equivalent to normalize the weights ? HOT 2
- Good bug in your implementation of AdamP HOT 1
- learning rate scheduler for adamp? HOT 3
- The difference with Adam and AdamP in the code HOT 3
- Experiment of Adam with warm up? HOT 2
- Question about eq (5) in section 2.3 HOT 1
- Depereciation warning in pytorch 1.5 (maybe and above?) HOT 4
- Builtin cosine_similarity HOT 4
- Recommended value to weight_decay for AdamP? HOT 1
- Runtime: Adam vs AdamP HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adamp.