GithubHelp home page GithubHelp logo

Comments (6)

adipose avatar adipose commented on June 26, 2024 2

So, I made a really simple fix that should handle this situation. If you name your toolbar color_toolbar.bmp, it will assume it doesn't need to create its own grayscale image and use the built-in capabilities. Otherwise, it grays the image normally. This should isolate the fix to anyone who feels secure enough to name it color_toolbar. :)

See:

#166

from mpc-hc.

clsid2 avatar clsid2 commented on June 26, 2024 1

Patch has been committed.

from mpc-hc.

clsid2 avatar clsid2 commented on June 26, 2024

The problem is that for most toolbars the disabled buttons look the same as the enabled ones if the current behavior is reverted. And I am not very keen on adding another option. Hiding disabled buttons may be an alternative.

That other patch is to prevent accidental clicks on the video just above the seekbar.

from mpc-hc.

clsid2 avatar clsid2 commented on June 26, 2024

Detecting if it has 'proper' data in the alpha channel might be possible too.

How did you make your modified toolbar?

from mpc-hc.

Rikk avatar Rikk commented on June 26, 2024

I remember I got one image from https://trac.mpc-hc.org/wiki/Toolbar_images and used Photoshop to modify by adding colors. It uses Alpha channel for delimiting buttons as recommended in that page for 32bit bmp. I still dunno what was wrong and which this commit tried to fix.

from mpc-hc.

Rikk avatar Rikk commented on June 26, 2024

@adipose Works great, thank you!

from mpc-hc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.