LAVFilters included in the MPCHC 1.8.1 release crash about mpc-hc

[clsid2]

Fixed in 1.8.2

[clsid2]

I can reproduce the player closing with the above file. But only on Windows 10. Setting compatibility mode to Windows 8 avoids the problem.

I suspect there is a buffer overflow in the FFmpeg code that triggers this Windows 10 mitigation:
https://docs.microsoft.com/en-us/windows/security/threat-protection/overview-of-threat-mitigations-in-windows-10#windows-heap-protections

@Nevcairiel

[clsid2]

I have found the cause. This FFmpeg change is responsible:
http://git.videolan.org/?p=ffmpeg.git;a=commit;h=662558f985f50834eebe82d6b6854c66f33ab320

[Hrxn]

Can you upload a sample file that reproduces this behavior?

[vBm]

Someone on IRC also reported the same issue with Mission.Impossible.Ghost.Protocol.2011.720p.BluRay.x264-x0r

[Hrxn]

Does this happen for a shorter clip cut from that file as well?

[alessiot89]

I also encounter the same behaviour on a very small number of mkv files, so far all with xml chapters.

[clsid2]

Sample files please. Copy links here or send to [email protected]

I have partially download that MI file (too few seeds), but no crash on initial test.

[alessiot89]

Here (sorry for the 100MB download): https://mega.nz/#!TjpHxYxR!hy_G7HZSj3rmbRy9yYNMiXRgBkQ9QmYp1SrWhcQfPJs

Seeking with arrows or mouse does randomly crash the player.

[Vagmer]

Setting compatibility mode to Windows 8 avoids the problem.

Yep, confirmed as an instant fix on my end. Any ideas as to any possible disadvantages of running in compatibility mode, for now? I'm also using madVR as output renderer.

For what it's worth (if anything), here's another sample, of a video that triggers the crashes very often. I trimmed it to only 30 seconds so it's only 12 MB (note that it's a bit harder to get the seeking crash often when the file is so short, but it still appears consistently). 1fichier.com mirror | mega.nz mirror. Original filename is BTW [SGKK]_Bleach_-_365_(1280x720_h264_AAC)_[385F6E68].mkv, any similar file of this release you'd use would work the same.

[genuinefafa]

i can confirm both things: there is an issue on my windows 10 computer; using windows 8 compatibility fixes the problem.

[Vagmer]

Great work! Thank you! =)