pgsql RA: should remove the include rep_mode when moving from sync->async about resource-agents

[t-matsuo]

It's specification and it's described in meta-data.

But if many people face it, I'll consider avoiding it.

[dmuhamedagic]

@t-matsuo, is this the meaning of the rep_mode parameter:

rep_mode (string, [none]):
Replication mode may be set to "async" or "sync". Both require PostgreSQL 9.1 or later.
Once set, this parameter requires node_list, master_ip, and restore_command parameters,
as well as configuring postgresql for replication (in postgresql.conf and pg_hba.conf).

Would you accept the above as replacement?

---

Otherwise, you can relatively easily drop the line:

rep_mode_stg="include '$REP_MODE_CONF' # added by pgsql RA"
if fgrep -q "$rep_mode_stg" $OCF_RESKEY_config; then
sed -i "/$rep_mode_stg/d" $OCF_RESKEY_config
fi

Probably better than explaining stuff to users ;-)

P.S. The above code is absolutely untested. Recommend to put such a long string in a var rather than repeating it.

[t-matsuo]

Sorry about the late reply.
I'll take latter.

I'll make a patch and send a pull request.

[t-matsuo]

Could anyone close this issue ?

[kskmori]

Closing as #167 has merged.