asterisk: resource is not stopped when validate fails about resource-agents

[dmuhamedagic]

Right, stop should succeed if the environment is broken in some way. @madkiss, I believe this RA is your work, do you want to take a look.

[dmuhamedagic]

Hmm, @madkiss seems to be very busy.

[dmuhamedagic]

@madkiss, it's been a year now, please either comment or let us know if you don't want to take care of this anymore. Thanks.

[madkiss]

Hu?

madkiss@b2b4ec3

[dmuhamedagic]

So, cool :) Did you open a pull request perhaps?

[lge]

On Mon, Sep 30, 2013 at 12:39:19AM -0700, Martin Loschwitz wrote:

Hu?

madkiss@b2b4ec3

You are aware that this patch breaks "stop", always?

---

asterisk_validate() { echo "=== in validate"; }
this_is_not_what_you_intended()
{
[ "$1" != "stop" ] && asterisk_validate || exit $?
echo "=== I'm now going to do: $1"
}

this_is_not_what_you_intended start

this_is_not_what_you_intended stop

• this_is_not_what_you_intended start
• '[' start '!=' stop ']'
• asterisk_validate
• echo '=== in validate'
  === in validate
• echo '=== I'''m now going to do: start'

=== I'm now going to do: start
this_is_not_what_you_intended stop

• this_is_not_what_you_intended stop
• '[' stop '!=' stop ']'
• exit 1

Oops.

: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

[dmuhamedagic]

Moving to a new milestone just in case something happens in the meantime.