GithubHelp home page GithubHelp logo

Comments (2)

kskmori avatar kskmori commented on June 19, 2024
          add_interface $ifinfo $IFLABEL

I think that it does not really 'restore'; if lo:0 was configured at first and the RA was configured to use eth0:1 then lo:1 is 'restored' after a migration. Isn't that rather confusing?

Also the broadcast isn't restored either in the current implementation.
The correct way to fix would be that it should obtain the correct iflabel/broadcast etc. from lo via the ip command and save them to $VLDIR/$ipaddr file when removing the Virtual IP (in remove_conflicting_loopback()) and then use the saved information when restoring.

As for the former part of the patch, it can not support nic=eth0:iflabel format. We would like to continue to support that format in order to keep the backward compatibility. I realized that the recent code did not work with it and submitted a patch to fix it. It would be appreciated if you could rewrite a patch based on this fix:
#201

Finally, I am wondering if this issue is really worth to fix honestly.
Again, I think lvs_support (removing a virtual IP on lo) should be no longer necessary; I have many load-balancing systems around me using the LVS-DR, ldirectord and IPaddr2 without enabling lvs_support. They are well tested and running in production. I am really grad if you could let me know if you had any problems without lvs_support.

Thanks,

from resource-agents.

dmuhamedagic avatar dmuhamedagic commented on June 19, 2024

@tobiasstein do you want to discuss this further? Add code? Close?

from resource-agents.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.